From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752552Ab0CBKb4 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 2 Mar 2010 05:31:56 -0500
Received: from cantor.suse.de ([195.135.220.2]:41141 "EHLO mx1.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752277Ab0CBKby (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 2 Mar 2010 05:31:54 -0500
Date: Tue, 02 Mar 2010 11:31:53 +0100
Message-ID: <s5h3a0jui92.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Arseniy Lartsev <ars3n@yandex.ru>
Cc: linux-kernel@vger.kernel.org
Subject: Re: PROBLEM: Wrong bitrate when capturing sound from Creative webcam
In-Reply-To: <201002242018.45592.ars3n@yandex.ru>
References: <201002242018.45592.ars3n@yandex.ru>
User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.1
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

At Wed, 24 Feb 2010 20:18:38 +0300,
Arseniy Lartsev wrote:
> 
> Hello,
> 
> I've got an USB webcam (Creative VF0470 Live Cam Notebook). The problem
> is that sound from it's microphone is captured with wrong bitrate.
> Apparently it reports 16000 Hz while it should actually be 8000 (so
> the sound is 2x faster).
> 
> The following patch works for me:
> --- linux-2.6.33-rc8/sound/usb/usbaudio.c
> +++ linux-2.6.33-rc8-new/sound/usb/usbaudio.c
> @@ -2513,6 +2513,8 @@ static int parse_audio_format_rates(stru
>  			     chip->usb_id == USB_ID(0x0d8c, 0x0102)) &&
>  			    fp->altsetting == 5 && fp->maxpacksize == 392)
>  				rate = 96000;
> +			if ((rate == 16000) && (chip->usb_id = USB_ID(0x041e, 0x4068)))
> +				rate = 8000;
>  			fp->rate_table[fp->nr_rates] = rate;
>  			if (!fp->rate_min || rate < fp->rate_min)
>  				fp->rate_min = rate;
> 
> I'm not sure if this is correct, maybe there should be more conditions
> to identify this particular camera.

The change looks good to me.  Could you give your sign-off for merge,
preferably repost in a right patch style?


thanks,

Takashi