From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759017AbYHTQQ5 (ORCPT ); Wed, 20 Aug 2008 12:16:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755537AbYHTQQX (ORCPT ); Wed, 20 Aug 2008 12:16:23 -0400 Received: from mx2.suse.de ([195.135.220.15]:50873 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755212AbYHTQQP (ORCPT ); Wed, 20 Aug 2008 12:16:15 -0400 Date: Wed, 20 Aug 2008 18:16:13 +0200 Message-ID: From: Takashi Iwai To: linux-next@vger.kernel.org Cc: Andrew Morton , Stephen Rothwell , Johannes Berg , Rusty Russell , LKML , netdev@vger.kernel.org, video4linux-list@redhat.com Subject: CONFIG_KMOD breakage in next kernel User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.2 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, I found that CONFIG_KMOD was already removed in linux-next tree. This seems to result in many breakages. For example, I cannot mount a FAT device automatically because of failure of automatic loading of nls modules. My particular problem would be fixed by the patch below, but I found CONFIG_KMOD is still referred in many places. % find * -name '*.[ch]' | xargs grep -l CONFIG_KMOD drivers/media/video/w9968cf.c drivers/media/video/v4l2-common.c drivers/media/video/v4l1-compat.c drivers/media/video/usbvision/usbvision-video.c drivers/media/video/usbvision/usbvision-core.c drivers/media/video/vino.c drivers/media/video/cpia.c drivers/video/fbmem.c drivers/md/md.c drivers/net/irda/sir_dongle.c drivers/net/pppox.c drivers/net/ppp_generic.c drivers/mtd/mtdpart.c fs/char_dev.c fs/exec.c kernel/kmod.c net/dccp/ccid.c net/sunrpc/auth.c net/ipv4/devinet.c net/ipv4/inet_diag.c net/ipv4/tcp_cong.c net/bluetooth/af_bluetooth.c net/sched/cls_api.c net/sched/act_api.c net/sched/ematch.c net/sched/sch_api.c net/can/af_can.c net/core/rtnetlink.c net/core/dev.c net/decnet/dn_dev.c net/netlink/af_netlink.c net/socket.c net/netfilter/nfnetlink.c net/bridge/netfilter/ebtables.c Anyone working on this? It must be trivial. Or, revert the following for the time being until all these are fixed: commit ba90ad7a589abdf59553a622c35cc149a348034f Author: Johannes Berg Date: Tue Jul 8 19:00:26 2008 +0200 remove CONFIG_KMOD Now that nothing depends on it any more, remove CONFIG_KMOD. Signed-off-by: Johannes Berg Signed-off-by: Rusty Russell thanks, Takashi --- diff --git a/fs/nls/nls_base.c b/fs/nls/nls_base.c index 64965e1..9f1a54c 100644 --- a/fs/nls/nls_base.c +++ b/fs/nls/nls_base.c @@ -13,9 +13,6 @@ #include #include #include -#ifdef CONFIG_KMOD -#include -#endif #include static struct nls_table default_table; @@ -216,7 +213,7 @@ static struct nls_table *find_nls(char *charset) struct nls_table *load_nls(char *charset) { struct nls_table *nls; -#ifdef CONFIG_KMOD +#ifdef CONFIG_MODULES int ret; #endif @@ -224,7 +221,7 @@ struct nls_table *load_nls(char *charset) if (nls) return nls; -#ifdef CONFIG_KMOD +#ifdef CONFIG_MODULES ret = request_module("nls_%s", charset); if (ret != 0) { printk("Unable to load NLS charset %s\n", charset);