From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754139AbYDXJlD (ORCPT ); Thu, 24 Apr 2008 05:41:03 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751056AbYDXJkx (ORCPT ); Thu, 24 Apr 2008 05:40:53 -0400 Received: from cantor2.suse.de ([195.135.220.15]:39365 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751140AbYDXJkv (ORCPT ); Thu, 24 Apr 2008 05:40:51 -0400 Date: Thu, 24 Apr 2008 11:40:50 +0200 Message-ID: From: Takashi Iwai To: Stas Sergeev Cc: linux-kernel@vger.kernel.org Subject: Re: 2.6.25-mm1 (snd-pcsp doesn't like DEBUG_PAGEALLOC) In-Reply-To: <480F95BE.60109@aknet.ru> References: <20080418014757.52fb4a4f.akpm@linux-foundation.org> <20080419021343.GA3503@nineveh.local> <20080418200237.b5a9e805.akpm@linux-foundation.org> <20080419041429.GA8508@anvil.corenet.prv> <20080418212934.bbe84ee2.akpm@linux-foundation.org> <480CD50F.20706@aknet.ru> <480E2EE5.5040208@aknet.ru> <480F95BE.60109@aknet.ru> User-Agent: Wanderlust/2.15.5 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta28) (fuki) (+CVS-20070806) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Thu, 24 Apr 2008 00:02:06 +0400, Stas Sergeev wrote: > > Hello. > > Takashi Iwai wrote: > >> + printk(KERN_WARNING "PCSP: CONFIG_DEBUG_PAGEALLOC is enabled, " > >> + KERN_WARNING "which may make the sound noisy.\n"); > > Missing \n in the first line? > This was intentional - wanted it to > print in a single line. You see a space > there for that reason. > Should the second KERN_WARNING be removed > then, or what is the problem exactly? Then you don't need KERN_WARNING there. The problem is that you need KERN_* prefix again after the line break (\n). Your original patch didn't do that properly. > >> - Prevent pcspkr from being built together > >> > with snd-pcsp. > >> > > >> > Signed-off-by: Stas Sergeev > > Thanks, applied to my git tree. > > git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6.git > > Meanwhile, we need to add a similar depenency to snd-pcsp as well, no? > I personally don't think so. > snd-pcsp has the excact copy of the pcspkr > code built-in, so I thought pcspkr can be > obsoleted in the future. From that point of > view, having snd-pcsp enabled and not even > seeing pcspkr in a menuconfig is fine. > While otherwise (you ocasionally enable > pcspkr and don't even see snd-pcsp then) > is not fine. No, I don't think input-pcspkr would be ever easily obsoleted by snd-pcsp. People definitely want a system without the sound subsystem but with a beep. > You mentioned earlier that you would like > to be able to swap those drivers dynamically, > but... what's the use? With such a dependancy > added, many people will not even know about > snd-pcsp as they already have pcspkr enabled. Think about distro. They could distribute both modules if both modules can be replacible. Otherwise, snd-pcsp won't be enabled on most distros, I guess. Takashi