From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1763504AbXGFJZi@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1763504AbXGFJZi (ORCPT <rfc822;w@1wt.eu>);
	Fri, 6 Jul 2007 05:25:38 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761373AbXGFJZ3
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Fri, 6 Jul 2007 05:25:29 -0400
Received: from cantor2.suse.de ([195.135.220.15]:49341 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1760741AbXGFJZ2 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 6 Jul 2007 05:25:28 -0400
Date: Fri, 06 Jul 2007 11:25:22 +0200
Message-ID: <s5h3b016fzx.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: "Adrian McMenamin" <adrianmcmenamin@gmail.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH] ALSA AICA sound on SEGA Dreamcast - fix	behaviour in poor resource conditions
In-Reply-To: <92a12cdb0707051507r7ab1516blb7ea755d89c25efa@mail.gmail.com>
References: <92a12cdb0707051507r7ab1516blb7ea755d89c25efa@mail.gmail.com>
User-Agent: Wanderlust/2.15.5 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta27)
 (fiddleheads) (+CVS-20060704) (i386-suse-linux)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

At Thu, 5 Jul 2007 23:07:44 +0100,
Adrian McMenamin wrote:
> @@ -402,17 +396,10 @@
>  static int snd_aicapcm_pcm_trigger(struct snd_pcm_substream
>  				   *substream, int cmd)
>  {
> -	struct snd_card_aica *dreamcastcard;
>  	switch (cmd) {
>  	case SNDRV_PCM_TRIGGER_START:
>  		spu_begin_dma(substream);
>  		break;
> -	case SNDRV_PCM_TRIGGER_STOP:
> -		dreamcastcard = substream->pcm->private_data;
> -		if (dreamcastcard->timer.data)
> -			del_timer(&dreamcastcard->timer);
> -		aica_chn_halt();
> -		break;
>  	default:
>  		return -EINVAL;
>  	}

Is this a correct change?  Then you'd have no control for stopping the
stream.

(BTW, your embedded patch was malformed...)


thanks,

Takashi