From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750808AbWFWOuv (ORCPT ); Fri, 23 Jun 2006 10:50:51 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750809AbWFWOuv (ORCPT ); Fri, 23 Jun 2006 10:50:51 -0400 Received: from ns.suse.de ([195.135.220.2]:14004 "EHLO mx1.suse.de") by vger.kernel.org with ESMTP id S1750808AbWFWOuu (ORCPT ); Fri, 23 Jun 2006 10:50:50 -0400 Date: Fri, 23 Jun 2006 16:50:49 +0200 Message-ID: From: Takashi Iwai To: Johannes Berg Cc: Paul Collins , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [Alsa-devel] all-modular snd-aoa In-Reply-To: <1151073390.7608.38.camel@localhost> References: <87hd2cz116.fsf@briny.internal.ondioline.org> <1151072095.7608.29.camel@localhost> <1151073390.7608.38.camel@localhost> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta25) (eggplant) (+CVS-20060326) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org At Fri, 23 Jun 2006 16:36:30 +0200, Johannes Berg wrote: > > On Fri, 2006-06-23 at 16:30 +0200, Takashi Iwai wrote: > > > Where is the problem in Makefile? It looks OK to me... > > Well, the problem is the fact the snd-aoa/ dir contains nothing to be > compiled and the kernel Makefiles don't like that. Then it's eaiser to fix sound/Makefile. --- a/sound/Makefile Fri Jun 23 15:18:41 2006 +0200 +++ b/sound/Makefile Fri Jun 23 16:49:15 2006 +0200 @@ -4,7 +4,8 @@ obj-$(CONFIG_SOUND) += soundcore.o obj-$(CONFIG_SOUND) += soundcore.o obj-$(CONFIG_SOUND_PRIME) += oss/ obj-$(CONFIG_DMASOUND) += oss/ -obj-$(CONFIG_SND) += core/ i2c/ drivers/ isa/ pci/ ppc/ arm/ synth/ usb/ sparc/ parisc/ pcmcia/ mips/ aoa/ +obj-$(CONFIG_SND) += core/ i2c/ drivers/ isa/ pci/ ppc/ arm/ synth/ usb/ sparc/ parisc/ pcmcia/ mips/ +obj-$(CONFIG_SND_AOA) += aoa/ ifeq ($(CONFIG_SND),y) obj-y += last.o > > Nevertheless, aoa/Kconfig has a wrong dependency on SND_PCM. > > Good point. Committing to my repository, how should we process things > like that now? Should I post some patches once a while or do you want to > commit that right away? Post patches to alsa-devel (and Cc to me). Will be pushed together with other fixes. Takashi