From: Takashi Iwai <tiwai@suse.de>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: lkml <linux-kernel@vger.kernel.org>, akpm <akpm@osdl.org>, perex@suse.cz
Subject: Re: [Ubuntu PATCH] ALSA: Add hp_only quirk for pci id [161f:2032] to via82xx
Date: Fri, 16 Jun 2006 16:22:44 +0200 [thread overview]
Message-ID: <s5h3be56uyz.wl%tiwai@suse.de> (raw)
In-Reply-To: <4491BC71.1090206@oracle.com>
At Thu, 15 Jun 2006 13:00:49 -0700,
Randy Dunlap wrote:
>
> From: crimsun@fungus.sh.nu <crimsun@fungus.sh.nu>
>
> [UBUNTU:sound/pci/] Add hp_only quirk for pci id [161f:2032] to via82xx ALSA driver
>
> http://www.kernel.org/git/?p=linux/kernel/git/bcollins/ubuntu-dapper.git;a=commitdiff;h=eae2cc78de39502595f67b7fc1f821f5963bb8ae
>
> UpstreamStatus: Not merged
>
> Christian Bjalevik reports in LP#38546 that his sound chipset requires
> the "hp_only" quirk to allow him to control sound volume correctly when
> headphones are inserted. This patch adds the appropriate pci id to the
> via82xx ALSA driver so that the quirk is applied automatically, thereby
> removing the need for users to modify /etc/modprobe.d/alsa-base (or to
> unload and reload snd-via82xx with ac97_quirk=hp_only).
>
> This patch closes LP#38546.
>
> Signed-off-by: Daniel T Chen <crimsun@ubuntu.com>
> Signed-off-by: Ben Collins <bcollins@ubuntu.com>
Thanks, I applied it to ALSA HG tree, too.
Takashi
> ---
> sound/pci/via82xx.c | 6 ++++++
> 1 files changed, 6 insertions(+)
>
> --- linux-2617-rc6g7.orig/sound/pci/via82xx.c
> +++ linux-2617-rc6g7/sound/pci/via82xx.c
> @@ -1775,6 +1775,12 @@ static struct ac97_quirk ac97_quirks[] =
> .name = "Targa Traveller 811",
> .type = AC97_TUNE_HP_ONLY,
> },
> + {
> + .subvendor = 0x161f,
> + .subdevice = 0x2032,
> + .name = "m680x",
> + .type = AC97_TUNE_HP_ONLY, /* http://launchpad.net/bugs/38546 */
> + },
> { } /* terminator */
> };
>
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
prev parent reply other threads:[~2006-06-16 14:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-15 20:00 Randy Dunlap
2006-06-16 14:22 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h3be56uyz.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@suse.cz \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®