From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32485C1B0F2 for ; Wed, 20 Jun 2018 14:18:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E89AE20872 for ; Wed, 20 Jun 2018 14:18:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E89AE20872 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754139AbeFTOSO (ORCPT ); Wed, 20 Jun 2018 10:18:14 -0400 Received: from mx2.suse.de ([195.135.220.15]:58292 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753832AbeFTOSN (ORCPT ); Wed, 20 Jun 2018 10:18:13 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext-too.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 1BF0FAFCF; Wed, 20 Jun 2018 14:18:12 +0000 (UTC) Date: Wed, 20 Jun 2018 16:18:12 +0200 Message-ID: From: Takashi Iwai To: Steven Rostedt Cc: Petr Mladek , Hans de Goede , Sergey Senozhatsky , linux-kernel@vger.kernel.org Subject: Re: [PATCH] printk: Make CONSOLE_LOGLEVEL_QUIET configurable In-Reply-To: <20180620100753.7acaee14@gandalf.local.home> References: <20180619115726.3098-1-hdegoede@redhat.com> <20180620110335.sjzmtra2z3chvon2@pathway.suse.cz> <20180620100753.7acaee14@gandalf.local.home> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 20 Jun 2018 16:07:53 +0200, Steven Rostedt wrote: > > On Wed, 20 Jun 2018 13:03:35 +0200 > Petr Mladek wrote: > > > I find it a bit confusing that "quiet" would mean something different > > on different systems. > > I disagree. "quiet" to me is for people that really don't care to see > anything from the kernel except for real issues that they need to > report. The first thing that I do, and many other kernel developers I > know, when installing a new distro, is to remove the "quiet" from the > command line. Because *I* care about the output. > > > > > > Why did not you use loglevel= instead of "quiet"? > > > > Alternative solution would be to add "silent" or so to calm down > > everything. But I am afraid that any change in this area would > > just create a mess similar to grep -s and -q options. > > > > > > Best Regards, > > Petr > > > > PS: I will not block it if Steven and Sergey are fine with this. But > > I want to be sure that they considered the above views. It looked like > > a no-brainer to me at the beginning. I even pushed this to printk.git. > > But the pushing gave me some more time to think about it... > > I prefer this patch over adding yet another kernel command line command > that will just add to the confusion. I can imagine people saying > "what's the difference between 'quiet' and 'silent'?". I would. > > I think having it as a config option is the perfect solution. I imagine > that as soon as Red Hat changes the meaning of "quiet" so will all the > other distros. Yeah, SUSE has gathered a pile of such bug reports and complaints from customers, too, so we'd happily follow that :) thanks, Takashi