From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754227AbdEQMU7 (ORCPT ); Wed, 17 May 2017 08:20:59 -0400 Received: from mx2.suse.de ([195.135.220.15]:34894 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751445AbdEQMU4 (ORCPT ); Wed, 17 May 2017 08:20:56 -0400 Date: Wed, 17 May 2017 14:20:54 +0200 Message-ID: From: Takashi Iwai To: "Bhumika Goyal" Cc: , , , Subject: Re: [PATCH] ALSA: sound/isa: constify snd_kcontrol_new structures In-Reply-To: <1495021136-6999-1-git-send-email-bhumirks@gmail.com> References: <1495021136-6999-1-git-send-email-bhumirks@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 17 May 2017 13:38:56 +0200, Bhumika Goyal wrote: > > Declare snd_kcontrol_new structures as const as they are only passed an > argument to the function snd_ctl_new1. This argument is of type const, > so snd_kcontrol_new structures having this property can be made const. > Done using Coccinelle: > > @r disable optional_qualifier@ > identifier x; > position p; > @@ > static struct snd_kcontrol_new x@p={...}; > > @ok@ > identifier r.x; > position p; > @@ > snd_ctl_new1(&x@p,...) > > @bad@ > position p != {r.p,ok.p}; > identifier r.x; > @@ > x@p > > @depends on !bad disable optional_qualifier@ > identifier r.x; > @@ > +const > struct snd_kcontrol_new x; > > Signed-off-by: Bhumika Goyal As I already asked, could you send as a patchset if you have multiple similar patches? thanks, Takashi