From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S945550AbdDTNBi (ORCPT <rfc822;w@1wt.eu>);
        Thu, 20 Apr 2017 09:01:38 -0400
Received: from mx2.suse.de ([195.135.220.15]:41604 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S942871AbdDTNBd (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 20 Apr 2017 09:01:33 -0400
Date: Thu, 20 Apr 2017 15:01:31 +0200
Message-ID: <s5h4lxjnsgk.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: Arnd Bergmann <arnd@arndb.de>, alsa-devel@alsa-project.org,
        Clemens Ladisch <clemens@ladisch.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: firewire-motu: mark trace helpers as __maybe_unused
In-Reply-To: <f6d6ac28-12ad-1845-6fac-7b5f7de6da39@sakamocchi.jp>
References: <20170419175158.5607-1-arnd@arndb.de>
        <s5hd1c7nyho.wl-tiwai@suse.de>
        <f6d6ac28-12ad-1845-6fac-7b5f7de6da39@sakamocchi.jp>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.1
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 20 Apr 2017 14:52:13 +0200,
Takashi Sakamoto wrote:
> 
> Hi,
> 
> On 2017年04月20日 19:51, Takashi Iwai wrote:
> > On Wed, 19 Apr 2017 19:51:29 +0200,
> > Arnd Bergmann wrote:
> >>
> >> Two functions were introduced for the purpose of tracing but cause warnings
> >> when tracing is disabled:
> >>
> >> sound/firewire/motu/amdtp-motu.c:284:13: error: 'copy_message' defined but not used [-Werror=unused-function]
> >>  static void copy_message(u64 *frames, __be32 *buffer, unsigned int data_blocks,
> >> sound/firewire/motu/amdtp-motu.c:271:13: error: 'copy_sph' defined but not used [-Werror=unused-function]
> >>  static void copy_sph(u32 *frames, __be32 *buffer, unsigned int data_blocks,
> >>
> >> Marking them as __maybe_unused will do the right thing here.
> >>
> >> Fixes: 17909c1b3058 ("ALSA: firewire-motu: add tracepoints for SPH in IEC 61883-1 fashion")
> >> Fixes: c6b0b9e65f09 ("ALSA: firewire-motu: add tracepoints for messages for unique protocol")
> >> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >
> > Applied, thanks.
> 
> Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
> 
> I note that Documentation/process/coding-style.rst describes:
> 'If you have a function or variable which may potentially go unused in a
> particular configuration, and the compiler would warn about its
> definition going unused, mark the definition as __maybe_unused rather
> than wrapping it in a preprocessor conditional.'
> 
> Iwa-san, could I request you to apply below patch in the last week of
> this development period?
> http://mailman.alsa-project.org/pipermail/alsa-devel/2017-April/119806.html

Merged now, sorry for overlooking it.


thanks,

Takashi