From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754628AbdCTMPm (ORCPT ); Mon, 20 Mar 2017 08:15:42 -0400 Received: from mx2.suse.de ([195.135.220.15]:52459 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754053AbdCTMOl (ORCPT ); Mon, 20 Mar 2017 08:14:41 -0400 Date: Mon, 20 Mar 2017 12:55:28 +0100 Message-ID: From: Takashi Iwai To: "Matthias Kaehlcke" Cc: "Julia Lawall" , "Jaroslav Kysela" , "Sven Hahne" , , "Grant Grundler" , Subject: Re: [PATCH] ALSA: hda/ca0132: Remove double parentheses In-Reply-To: <20170315224123.175587-1-mka@chromium.org> References: <20170315224123.175587-1-mka@chromium.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 15 Mar 2017 23:41:23 +0100, Matthias Kaehlcke wrote: > > The extra pairs of parantheses are not needed and causes clang to > generate warnings like this: > > sound/pci/hda/patch_ca0132.c:1171:14: error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality] > if ((buffer == NULL)) > ~~~~~~~^~~~~~~ > sound/pci/hda/patch_ca0132.c:1171:14: note: remove extraneous parentheses around the comparison to silence this warning > if ((buffer == NULL)) > ~ ^ ~ > sound/pci/hda/patch_ca0132.c:1171:14: note: use '=' to turn this equality comparison into an assignment > if ((buffer == NULL)) > > Signed-off-by: Matthias Kaehlcke Applied, thanks. Takashi