From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753651AbcITKyc (ORCPT <rfc822;w@1wt.eu>);
        Tue, 20 Sep 2016 06:54:32 -0400
Received: from mx2.suse.de ([195.135.220.15]:53746 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751540AbcITKya (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 20 Sep 2016 06:54:30 -0400
Date: Tue, 20 Sep 2016 12:54:20 +0200
Message-ID: <s5h4m5au9ib.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: kbuild test robot <fengguang.wu@intel.com>
Cc: Andrej Krutak <dev@andree.sk>, kbuild-all@01.org,
        alsa-devel@alsa-project.org, Jaroslav Kysela <perex@perex.cz>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: line6: fix ifnullfree.cocci warnings
In-Reply-To: <20160920001013.GA15786@lkp-hsx03.lkp.intel.com>
References: <201609200807.amTCnbAm%fengguang.wu@intel.com>
        <20160920001013.GA15786@lkp-hsx03.lkp.intel.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 20 Sep 2016 02:10:13 +0200,
kbuild test robot wrote:
> 
> sound/usb/line6/driver.c:484:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.
> 
>  NULL check before some freeing functions is not needed.
> 
>  Based on checkpatch warning
>  "kfree(NULL) is safe this check is probably not required"
>  and kfreeaddr.cocci by Julia Lawall.
> 
> Generated by: scripts/coccinelle/free/ifnullfree.cocci
> 
> CC: Andrej Krutak <dev@andree.sk>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

Applied, thanks.


Takashi


> ---
> 
>  driver.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> --- a/sound/usb/line6/driver.c
> +++ b/sound/usb/line6/driver.c
> @@ -480,8 +480,7 @@ static void line6_destruct(struct snd_ca
>  	/* Free buffer memory first. We cannot depend on the existence of private
>  	 * data from the (podhd) module, it may be gone already during this call
>  	 */
> -	if (line6->buffer_message)
> -		kfree(line6->buffer_message);
> +	kfree(line6->buffer_message);
>  
>  	kfree(line6->buffer_listen);
>  
>