From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S936174AbcIPRZG (ORCPT <rfc822;w@1wt.eu>);
        Fri, 16 Sep 2016 13:25:06 -0400
Received: from mx2.suse.de ([195.135.220.15]:55757 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1755706AbcIPRY6 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 16 Sep 2016 13:24:58 -0400
Date: Fri, 16 Sep 2016 19:24:54 +0200
Message-ID: <s5h4m5foizd.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: "Colin King" <colin.king@canonical.com>
Cc: <alsa-devel@alsa-project.org>, "Jeeja KP" <jeeja.kp@intel.com>,
        "Subhransu S . Prusty" <subhransu.s.prusty@intel.com>,
        "Vinod Koul" <vinod.koul@intel.com>, "Mark Brown" <broonie@kernel.org>,
        <trivial@kernel.org>, "Jaroslav Kysela" <perex@perex.cz>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA: hdac: add missing \n to end of dev_err messages
In-Reply-To: <20160916163605.11615-1-colin.king@canonical.com>
References: <20160916163605.11615-1-colin.king@canonical.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 16 Sep 2016 18:36:05 +0200,
Colin King wrote:
> 
> From: Colin Ian King <colin.king@canonical.com>
> 
> Trival fix, some dev_err messages are missing a \n, so add it.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied, thanks.


Takashi

> ---
>  sound/hda/ext/hdac_ext_stream.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/sound/hda/ext/hdac_ext_stream.c b/sound/hda/ext/hdac_ext_stream.c
> index 2441273..3be051a 100644
> --- a/sound/hda/ext/hdac_ext_stream.c
> +++ b/sound/hda/ext/hdac_ext_stream.c
> @@ -424,7 +424,7 @@ void snd_hdac_ext_stream_spbcap_enable(struct hdac_ext_bus *ebus,
>  	struct hdac_bus *bus = &ebus->bus;
>  
>  	if (!bus->spbcap) {
> -		dev_err(bus->dev, "Address of SPB capability is NULL");
> +		dev_err(bus->dev, "Address of SPB capability is NULL\n");
>  		return;
>  	}
>  
> @@ -453,7 +453,7 @@ int snd_hdac_ext_stream_set_spib(struct hdac_ext_bus *ebus,
>  	struct hdac_bus *bus = &ebus->bus;
>  
>  	if (!bus->spbcap) {
> -		dev_err(bus->dev, "Address of SPB capability is NULL");
> +		dev_err(bus->dev, "Address of SPB capability is NULL\n");
>  		return -EINVAL;
>  	}
>  
> @@ -476,7 +476,7 @@ int snd_hdac_ext_stream_get_spbmaxfifo(struct hdac_ext_bus *ebus,
>  	struct hdac_bus *bus = &ebus->bus;
>  
>  	if (!bus->spbcap) {
> -		dev_err(bus->dev, "Address of SPB capability is NULL");
> +		dev_err(bus->dev, "Address of SPB capability is NULL\n");
>  		return -EINVAL;
>  	}
>  
> @@ -516,7 +516,7 @@ void snd_hdac_ext_stream_drsm_enable(struct hdac_ext_bus *ebus,
>  	struct hdac_bus *bus = &ebus->bus;
>  
>  	if (!bus->drsmcap) {
> -		dev_err(bus->dev, "Address of DRSM capability is NULL");
> +		dev_err(bus->dev, "Address of DRSM capability is NULL\n");
>  		return;
>  	}
>  
> @@ -545,7 +545,7 @@ int snd_hdac_ext_stream_set_dpibr(struct hdac_ext_bus *ebus,
>  	struct hdac_bus *bus = &ebus->bus;
>  
>  	if (!bus->drsmcap) {
> -		dev_err(bus->dev, "Address of DRSM capability is NULL");
> +		dev_err(bus->dev, "Address of DRSM capability is NULL\n");
>  		return -EINVAL;
>  	}
>  
> -- 
> 2.9.3
> 
>