From: Takashi Iwai <tiwai@suse.de>
To: Chris J Arges <chris.j.arges@canonical.com>
Cc: alsa-devel@vger.kernel.org, Jaroslav Kysela <perex@perex.cz>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: usb-audio: Fix Scarlett 6i6 initialization typo
Date: Thu, 18 Dec 2014 09:02:26 +0100 [thread overview]
Message-ID: <s5h4mstl71p.wl-tiwai@suse.de> (raw)
In-Reply-To: <1418854194-13837-1-git-send-email-chris.j.arges@canonical.com>
At Wed, 17 Dec 2014 16:09:35 -0600,
Chris J Arges wrote:
>
> The num_controls field was incorrectly set to 0 causing 6i6 to not be
> initialized. Set this to 9.
>
> Reported-and-tested-by: Mark Roberts <sunifiram@gmail.com>
> Signed-off-by: Chris J Arges <chris.j.arges@canonical.com>
Applied, thanks.
Takashi
> ---
> sound/usb/mixer_scarlett.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/usb/mixer_scarlett.c b/sound/usb/mixer_scarlett.c
> index 9109652..7438e7c 100644
> --- a/sound/usb/mixer_scarlett.c
> +++ b/sound/usb/mixer_scarlett.c
> @@ -655,7 +655,7 @@ static struct scarlett_device_info s6i6_info = {
> .names = NULL
> },
>
> - .num_controls = 0,
> + .num_controls = 9,
> .controls = {
> { .num = 0, .type = SCARLETT_OUTPUTS, .name = "Monitor" },
> { .num = 1, .type = SCARLETT_OUTPUTS, .name = "Headphone" },
> --
> 1.9.1
>
prev parent reply other threads:[~2014-12-18 8:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-17 22:09 Chris J Arges
2014-12-18 8:02 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h4mstl71p.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=alsa-devel@vger.kernel.org \
--cc=chris.j.arges@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®