From: Takashi Iwai <tiwai@suse.de>
To: Bryan Quigley <gquigs@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: PROBLEM: Pulseaudio hung at schedule in 3.15-rc1
Date: Sun, 20 Apr 2014 08:08:18 +0200 [thread overview]
Message-ID: <s5h4n1ov8h9.wl%tiwai@suse.de> (raw)
In-Reply-To: <CAAWf5=s-hQ2xMtLxNFXjXH6UGmQtgkrzS9zWj3z_CTq41XGpdw@mail.gmail.com>
At Sat, 19 Apr 2014 13:20:01 -0400,
Bryan Quigley wrote:
>
> 400362f1d8dcfda3562e80e88cfc2a92cffaf9bf is the first bad commit
> commit 400362f1d8dcfda3562e80e88cfc2a92cffaf9bf
> Author: Takashi Iwai <tiwai@suse.de>
> Date: Mon Jan 20 16:51:16 2014 +0100
>
> ALSA: usb-audio: Resume mixer values properly
>
> Implement reset_resume callback so that the mixer values are properly
> restored. Still no boot quirks are called, so it might not work well
> on some devices.
>
> Confirmed that a revert of that commit only fixes the issue.
Does the patch below work? I'm on vacation now, so the reply may be
delayed.
thanks,
Takashi
---
diff --git a/sound/usb/card.c b/sound/usb/card.c
index 893d5a1..d26fd9b 100644
--- a/sound/usb/card.c
+++ b/sound/usb/card.c
@@ -711,6 +711,7 @@ static int __usb_audio_resume(struct usb_interface *intf, bool reset_resume)
return 0;
if (--chip->num_suspended_intf)
return 0;
+ usb_autopm_get_interface_no_resume(chip->pm_intf);
/*
* ALSA leaves material resumption to user space
* we just notify and restart the mixers
@@ -726,6 +727,7 @@ static int __usb_audio_resume(struct usb_interface *intf, bool reset_resume)
chip->autosuspended = 0;
err_out:
+ usb_autopm_put_interface(chip->pm_intf);
return err;
}
next prev parent reply other threads:[~2014-04-20 6:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-19 17:20 Bryan Quigley
2014-04-20 6:08 ` Takashi Iwai [this message]
2014-04-20 18:50 ` Bryan Quigley
2014-04-29 14:21 ` Takashi Iwai
2014-04-29 18:04 ` Bryan Quigley
2014-04-30 6:42 ` Takashi Iwai
2014-04-30 16:10 ` Bryan Quigley
2014-04-30 16:36 ` Takashi Iwai
2014-04-30 17:40 ` Bryan Quigley
2014-05-02 7:36 ` Takashi Iwai
2014-05-02 14:33 ` Bryan Quigley
2014-05-07 21:15 ` Ed Tomlinson
-- strict thread matches above, loose matches on Subject: below --
2014-04-19 5:08 Bryan Quigley
2014-04-19 6:04 ` Bryan Quigley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h4n1ov8h9.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=gquigs@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®