From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752986AbaBLQU1 (ORCPT ); Wed, 12 Feb 2014 11:20:27 -0500 Received: from cantor2.suse.de ([195.135.220.15]:45962 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751942AbaBLQUW (ORCPT ); Wed, 12 Feb 2014 11:20:22 -0500 Date: Wed, 12 Feb 2014 17:20:21 +0100 Message-ID: From: Takashi Iwai To: Martin Kepplinger Cc: perex@perex.cz, david.henningsson@canonical.com, hui.wang@canonical.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [BUG]3.14-rc2 [PATCH] Revert "ALSA: hda/realtek - Avoid invalid COEFs for ALC271X" In-Reply-To: <1392221363-5447-1-git-send-email-martink@posteo.de> References: <1392221363-5447-1-git-send-email-martink@posteo.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Wed, 12 Feb 2014 17:09:23 +0100, Martin Kepplinger wrote: > > This reverts commit d3c56568f43807135f2c2a09582a69f809f0d8b7. > > The reverted commit breaks audio through headphone line out on > the Acer TravelMate B113 (Type1Sku0) Notebook, my main work > machine. I don't know much about it but this fixes my problem. > Bisected and tested. > > Tested-by: Martin Kepplinger > Signed-off-by: Martin Kepplinger Too bad, we need COEF for some machine but it breaks for some. Since reverting breaks obviously another machine, we need a different approach, e.g. checking the machine ID. Please give alsa-info.sh output of your machine. thanks, Takashi > --- > sound/pci/hda/patch_realtek.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index d9693ca..0f5af34 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -4434,9 +4434,6 @@ static void alc269_fill_coef(struct hda_codec *codec) > > if (spec->codec_variant != ALC269_TYPE_ALC269VB) > return; > - /* ALC271X doesn't seem to support these COEFs (bko#52181) */ > - if (!strcmp(codec->chip_name, "ALC271X")) > - return; > > if ((alc_get_coef0(codec) & 0x00ff) < 0x015) { > alc_write_coef_idx(codec, 0xf, 0x960b); > -- > 1.7.10.4 >