From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757847Ab3BKQGe (ORCPT ); Mon, 11 Feb 2013 11:06:34 -0500 Received: from cantor2.suse.de ([195.135.220.15]:38015 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757572Ab3BKQGd (ORCPT ); Mon, 11 Feb 2013 11:06:33 -0500 Date: Mon, 11 Feb 2013 17:06:32 +0100 Message-ID: From: Takashi Iwai To: Denis Efremov Cc: Bill Pemberton , linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: ali5451: remove irq enabling in pointer callback In-Reply-To: <1360597788-25614-1-git-send-email-yefremov.denis@gmail.com> References: <1360597788-25614-1-git-send-email-yefremov.denis@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Mon, 11 Feb 2013 19:49:48 +0400, Denis Efremov wrote: > > snd_ali_pointer function is called with local > interrupts disabled. However it seems very strange to > reenable them in such way. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Denis Efremov Thanks, applied now. Takashi > --- > sound/pci/ali5451/ali5451.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/pci/ali5451/ali5451.c b/sound/pci/ali5451/ali5451.c > index 136a393..e760af9 100644 > --- a/sound/pci/ali5451/ali5451.c > +++ b/sound/pci/ali5451/ali5451.c > @@ -1435,7 +1435,7 @@ static snd_pcm_uframes_t snd_ali_pointer(struct snd_pcm_substream *substream) > > spin_lock(&codec->reg_lock); > if (!pvoice->running) { > - spin_unlock_irq(&codec->reg_lock); > + spin_unlock(&codec->reg_lock); > return 0; > } > outb(pvoice->number, ALI_REG(codec, ALI_GC_CIR)); > -- > 1.8.1.2 >