From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752635Ab1GXL7d (ORCPT ); Sun, 24 Jul 2011 07:59:33 -0400 Received: from cantor2.suse.de ([195.135.220.15]:41448 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752515Ab1GXL71 (ORCPT ); Sun, 24 Jul 2011 07:59:27 -0400 Date: Sun, 24 Jul 2011 13:59:26 +0200 Message-ID: From: Takashi Iwai To: Lionel Debroux Cc: Jaroslav Kysela , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Kees Cook , Emese Revfy , kernel-janitors@vger.kernel.org Subject: Re: sound: constify snd_ac97_bus_ops In-Reply-To: <208430.5747.bm@smtp121.mail.ukl.yahoo.com> References: <208430.5747.bm@smtp121.mail.ukl.yahoo.com> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Sun, 24 Jul 2011 11:40:48 +0200, Lionel Debroux wrote: > > The fields of this struct type don't seem to be used as rvalues, besides > the initialization of struct instances. Let's make const the struct > instances. > > Maybe the Documentation/DocBook/writing-an-alsa-driver.tmpl, and > checkpatch.pl should be updated to reflect this change ? Yes, please either update or give an additional patch for document fixes. I'll apply these series not for 3.1 since this changes API. Will be applied the branches for 3.2. thanks, Takashi