From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755308Ab0LJLPg (ORCPT ); Fri, 10 Dec 2010 06:15:36 -0500 Received: from cantor2.suse.de ([195.135.220.15]:42790 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752257Ab0LJLPf (ORCPT ); Fri, 10 Dec 2010 06:15:35 -0500 Date: Fri, 10 Dec 2010 12:15:34 +0100 Message-ID: From: Takashi Iwai To: Axel Lin Cc: linux-kernel , Johannes Berg , alsa-devel@alsa-project.org Subject: Re: [PATCH] ALSA: aoa: Remove wrong i2c_set_clientdata in onyx_i2c_remove() In-Reply-To: <1291973666.27848.1.camel@mola> References: <1291973666.27848.1.camel@mola> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Fri, 10 Dec 2010 17:34:26 +0800, Axel Lin wrote: > > It does not make sense to set clientdata to onyx in onyx_i2c_remove() > as we are going to kfree onyx. > What we really want here is i2c_set_clientdata(client, NULL); > Since the i2c core will take care of it now, so this patch just removes it. > > Signed-off-by: Axel Lin Thanks, applied now. Takashi > --- > sound/aoa/codecs/onyx.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/sound/aoa/codecs/onyx.c b/sound/aoa/codecs/onyx.c > index 91852e4..3687a6c 100644 > --- a/sound/aoa/codecs/onyx.c > +++ b/sound/aoa/codecs/onyx.c > @@ -1114,7 +1114,6 @@ static int onyx_i2c_remove(struct i2c_client *client) > of_node_put(onyx->codec.node); > if (onyx->codec_info) > kfree(onyx->codec_info); > - i2c_set_clientdata(client, onyx); > kfree(onyx); > return 0; > } > -- > 1.7.2 > > >