From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756791Ab0G2Kbf (ORCPT ); Thu, 29 Jul 2010 06:31:35 -0400 Received: from cantor2.suse.de ([195.135.220.15]:51633 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756676Ab0G2Kbd (ORCPT ); Thu, 29 Jul 2010 06:31:33 -0400 Date: Thu, 29 Jul 2010 12:31:32 +0200 Message-ID: From: Takashi Iwai To: Kulikov Vasiliy Cc: kernel-janitors@vger.kernel.org, Jaroslav Kysela , Roel Kluin , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 08/10] oss: midi_synth: check get_user() return value In-Reply-To: <1280335277-23435-1-git-send-email-segooon@gmail.com> References: <1280335277-23435-1-git-send-email-segooon@gmail.com> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Wed, 28 Jul 2010 20:41:17 +0400, Kulikov Vasiliy wrote: > > get_user() may fail, if so return -EFAULT. > > Signed-off-by: Kulikov Vasiliy Applied now. Thanks. Takashi > --- > sound/oss/midi_synth.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/sound/oss/midi_synth.c b/sound/oss/midi_synth.c > index 3bc7104..3c09374 100644 > --- a/sound/oss/midi_synth.c > +++ b/sound/oss/midi_synth.c > @@ -523,7 +523,9 @@ midi_synth_load_patch(int dev, int format, const char __user *addr, > { > unsigned char data; > > - get_user(*(unsigned char *) &data, (unsigned char __user *) &((addr)[hdr_size + i])); > + if (get_user(data, > + (unsigned char __user *)(addr + hdr_size + i))) > + return -EFAULT; > > eox_seen = (i > 0 && data & 0x80); /* End of sysex */ > > -- > 1.7.0.4 >