From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751398AbZL1LfG (ORCPT ); Mon, 28 Dec 2009 06:35:06 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751271AbZL1LfF (ORCPT ); Mon, 28 Dec 2009 06:35:05 -0500 Received: from cantor2.suse.de ([195.135.220.15]:39046 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751268AbZL1LfB (ORCPT ); Mon, 28 Dec 2009 06:35:01 -0500 Date: Mon, 28 Dec 2009 12:35:00 +0100 Message-ID: From: Takashi Iwai To: Roel Kluin Cc: Jaroslav Kysela , alsa-devel@alsa-project.org, Andrew Morton , LKML Subject: Re: [PATCH] ALSA: test off by one in setsamplerate() In-Reply-To: <4B37D117.3000700@gmail.com> References: <4B37D117.3000700@gmail.com> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Sun, 27 Dec 2009 22:26:47 +0100, Roel Kluin wrote: > > With `while (i++ < MAX_WRITE_RETRY)' i reaches MAX_WRITE_RETRY + 1 after the loop > > Signed-off-by: Roel Kluin Applied now. Thanks. Takashi > --- > sound/pci/riptide/riptide.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/sound/pci/riptide/riptide.c b/sound/pci/riptide/riptide.c > index b5ca02e..e66ef2b 100644 > --- a/sound/pci/riptide/riptide.c > +++ b/sound/pci/riptide/riptide.c > @@ -1058,7 +1058,7 @@ setsamplerate(struct cmdif *cif, unsigned char *intdec, unsigned int rate) > rptr.retwords[2] != M && > rptr.retwords[3] != N && > i++ < MAX_WRITE_RETRY); > - if (i == MAX_WRITE_RETRY) { > + if (i > MAX_WRITE_RETRY) { > snd_printdd("sent samplerate %d: %d failed\n", > *intdec, rate); > return -EIO; >