mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: hpa@zytor.com, mingo@redhat.com, dwmw2@infradead.org,
	acme@ghostprotocols.net, airlied@linux.ie, perex@perex.cz,
	yoshfuji@linux-ipv6.org, mchehab@redhat.com, arnd@arndb.de,
	tglx@linutronix.de, hpa@linux.intel.com,
	linux-kernel@vger.kernel.org
Subject: Re: [tip:core/header-fixes] make most exported headers use strict integer types
Date: Thu, 26 Feb 2009 09:47:42 +0100	[thread overview]
Message-ID: <s5h4oyhk2j5.wl%tiwai@suse.de> (raw)
In-Reply-To: <tip-57b4b9d7b56d283b6619a893341be16d1a0467a6@kernel.org>

At Thu, 26 Feb 2009 01:31:04 GMT,
Arnd Bergmann wrote:
> 
> diff --git a/include/sound/emu10k1.h b/include/sound/emu10k1.h
> index 10ee28e..c380056 100644
> --- a/include/sound/emu10k1.h
> +++ b/include/sound/emu10k1.h
> @@ -1,6 +1,8 @@
>  #ifndef __SOUND_EMU10K1_H
>  #define __SOUND_EMU10K1_H
>  
> +#include <linux/types.h>
> +
>  /*
>   *  Copyright (c) by Jaroslav Kysela <perex@perex.cz>,
>   *		     Creative Labs, Inc.
> @@ -34,6 +36,8 @@
>  #include <sound/timer.h>
>  #include <linux/interrupt.h>
>  #include <linux/mutex.h>
> +#include <linux/types.h>
> +

Isn't the second inclusion superfluous?


thanks,

Takashi

       reply	other threads:[~2009-02-26  8:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <tip-57b4b9d7b56d283b6619a893341be16d1a0467a6@kernel.org>
2009-02-26  8:47 ` Takashi Iwai [this message]
2009-02-26  8:57   ` [PATCH] fix duplicate include in emu10k1.h Arnd Bergmann
2009-02-26  9:03     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h4oyhk2j5.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=acme@ghostprotocols.net \
    --cc=airlied@linux.ie \
    --cc=arnd@arndb.de \
    --cc=dwmw2@infradead.org \
    --cc=hpa@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@redhat.com \
    --cc=mingo@redhat.com \
    --cc=perex@perex.cz \
    --cc=tglx@linutronix.de \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®