From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757977AbYEWPTl (ORCPT ); Fri, 23 May 2008 11:19:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753079AbYEWPTe (ORCPT ); Fri, 23 May 2008 11:19:34 -0400 Received: from ns.suse.de ([195.135.220.2]:41588 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752972AbYEWPTd (ORCPT ); Fri, 23 May 2008 11:19:33 -0400 Date: Fri, 23 May 2008 17:19:32 +0200 Message-ID: From: Takashi Iwai To: David Woodhouse Cc: linux-kernel@vger.kernel.org, aoliva@redhat.com, alan@lxorguk.ukuu.org.uk, Abhay Salunke , kay.sievers@vrfy.org, Haroldo Gamal Subject: Re: [PATCH 1/3] firmware: allow firmware files to be built into kernel image In-Reply-To: <1211554711.28967.25.camel@pmac.infradead.org> References: <1211550282.28967.8.camel@pmac.infradead.org> <1211554711.28967.25.camel@pmac.infradead.org> User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta28) (fuki) (+CVS-20070806) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Fri, 23 May 2008 15:58:31 +0100, David Woodhouse wrote: > > On Fri, 2008-05-23 at 16:53 +0200, Takashi Iwai wrote: > > This looks like a nice cleanup. It'd be nicer if we can skip vmalloc > > and duplication of the image for static binaries. > > Yeah, I thought about that. I was slightly concerned that drivers might > actually try to _modify_ the firmware they loaded, though. As it is, > there's no fundamental reason why they shouldn't do that. Hm, but request_firmware() returns the const pointer. It implies that the caller shouldn't change the content, doesn't it? I cannot guarantee that there must be no misbehaving drivers, though... thanks, Takashi