From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762799AbYDVK4R (ORCPT ); Tue, 22 Apr 2008 06:56:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755231AbYDVK4B (ORCPT ); Tue, 22 Apr 2008 06:56:01 -0400 Received: from mail.suse.de ([195.135.220.2]:38038 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755224AbYDVK4A (ORCPT ); Tue, 22 Apr 2008 06:56:00 -0400 Date: Tue, 22 Apr 2008 12:55:56 +0200 Message-ID: From: Takashi Iwai To: Jeff Garzik Cc: perex@perex.cz, LKML , Andrew Morton Subject: Re: [PATCH 1/2] ALSA: Fix synchronize_irq() bugs, redundancies In-Reply-To: <20080421233419.GA4923@havoc.gtf.org> References: <20080421233419.GA4923@havoc.gtf.org> User-Agent: Wanderlust/2.15.5 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta28) (fuki) (+CVS-20070806) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Mon, 21 Apr 2008 19:34:19 -0400, Jeff Garzik wrote: > > free_irq() calls synchronize_irq() for you, so there is no need for > drivers to manually do the same thing (again). Thus, calls where > sync-irq immediately precedes free-irq can be simplified. > > However, during this audit several bugs were noticed, where free-irq is > preceded by a "irq >= 0" check... but the sync-irq call is not covered > by the same check. > > So, where sync-irq could not be eliminated completely, the missing check > was added. > > Signed-off-by: Jeff Garzik Thanks, I applied to ALSA tree now. Takashi