From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756268AbYDNK2h (ORCPT ); Mon, 14 Apr 2008 06:28:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751296AbYDNK2a (ORCPT ); Mon, 14 Apr 2008 06:28:30 -0400 Received: from cantor2.suse.de ([195.135.220.15]:51469 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751423AbYDNK23 (ORCPT ); Mon, 14 Apr 2008 06:28:29 -0400 Date: Mon, 14 Apr 2008 12:28:27 +0200 Message-ID: From: Takashi Iwai To: Denys Vlasenko Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] sound/pci/rme9652/hdspm.c: stop inlining largish static functions In-Reply-To: <200804010436.48348.vda.linux@googlemail.com> References: <200804010436.48348.vda.linux@googlemail.com> User-Agent: Wanderlust/2.15.5 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta28) (fuki) (+CVS-20070806) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Tue, 1 Apr 2008 04:36:48 +0200, Denys Vlasenko wrote: > > Hi Takashi, > > Can you please take a look at this patch? > > sound/pci/rme9652/hdspm.c has unusually large number > of static inline functions - 22. > > I looked through them and some of them seem to be too big > to warrant inlining. > > This patch removes "inline" from these static functions > (regardless of number of callsites - gcc nowadays auto-inlines > statics with one callsite). > > Size difference on 32bit x86: > text data bss dec hex filename > 20437 2160 516 23113 5a49 linux-2.6-ALLYES/sound/pci/rme9652/hdspm.o > 18036 2160 516 20712 50e8 linux-2.6.inline-ALLYES/sound/pci/rme9652/hdspm.o > > Signed-off-by: Denys Vlasenko > -- > vda Thanks for the patch. I applied it to ALSA tree together with coding style fixes. Takashi