From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756075AbXFZJKk (ORCPT ); Tue, 26 Jun 2007 05:10:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751558AbXFZJKd (ORCPT ); Tue, 26 Jun 2007 05:10:33 -0400 Received: from ns1.suse.de ([195.135.220.2]:41978 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751531AbXFZJKc (ORCPT ); Tue, 26 Jun 2007 05:10:32 -0400 Date: Tue, 26 Jun 2007 11:10:27 +0200 Message-ID: From: Takashi Iwai To: Andrew Morton Cc: Randy Dunlap , lkml , perex@suse.cz Subject: Re: [PATCH] ALSA: fix ice1712 section mismatch In-Reply-To: <20070625164110.94ecade1.akpm@linux-foundation.org> References: <20070625161739.8115c40c.randy.dunlap@oracle.com> <20070625164110.94ecade1.akpm@linux-foundation.org> User-Agent: Wanderlust/2.15.5 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta27) (fiddleheads) (+CVS-20060704) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org At Mon, 25 Jun 2007 16:41:10 -0700, Andrew Morton wrote: > > On Mon, 25 Jun 2007 16:17:39 -0700 Randy Dunlap > wrote: > > > From: Randy Dunlap > > > > Cannot mix const and __initdata: > > sound/pci/ice1712/prodigy192.c:708: error: ak4114_controls causes a section type conflict > > > > This is a fatal compilation error, isn't it? > > > --- > > sound/pci/ice1712/prodigy192.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > --- linux-2.6.22-rc6.orig/sound/pci/ice1712/prodigy192.c > > +++ linux-2.6.22-rc6/sound/pci/ice1712/prodigy192.c > > @@ -705,7 +705,7 @@ static int ak4114_input_sw_put(struct sn > > } > > > > > > -static const struct snd_kcontrol_new ak4114_controls[] __devinitdata = { > > +static struct snd_kcontrol_new ak4114_controls[] __devinitdata = { > > { > > .iface = SNDRV_CTL_ELEM_IFACE_MIXER, > > .name = "MIODIO IEC958 Capture Input", > > That patch is already in the alsa git tree (has been there for five days), > so I would of course prefer that the alsa guys merge it into 2.6.22. Jaroslav, could you prepare the push? > However alsa merges are a bit spotty, so I'll queue this up anyway and will > merge it in a day or three if nothing else happens, OK? Yes, I think it's perhaps an easier path... Thanks! Takashi