From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751027AbVJSPDy (ORCPT ); Wed, 19 Oct 2005 11:03:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751039AbVJSPDy (ORCPT ); Wed, 19 Oct 2005 11:03:54 -0400 Received: from mail.suse.de ([195.135.220.2]:64679 "EHLO mx1.suse.de") by vger.kernel.org with ESMTP id S1751027AbVJSPDy (ORCPT ); Wed, 19 Oct 2005 11:03:54 -0400 Date: Wed, 19 Oct 2005 17:03:46 +0200 Message-ID: From: Takashi Iwai To: "John W. Linville" Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, perex@suse.cz Subject: Re: [patch 2.6.14-rc4] nm256: reset workaround for Latitude CSx In-Reply-To: <10182005213102.13024@bilbo.tuxdriver.com> References: <10182005213102.13024@bilbo.tuxdriver.com> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta18) (chestnut) (+CVS-20041021) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org At Tue, 18 Oct 2005 21:31:02 -0400, John W. Linville wrote: > > The current snd-nm256 driver can cause Dell Latitude CSx laptops to > lock-up during module (un)load. I have isolated this to the writes to > the control port register at offset 0x6cc which were not already > protected by the existing reset_workaround. > > I tried grouping these writes with the existing reset_workaround > clause, but that caused the driver to have (un)load problems on the > Dell Latitude LS laptops. So, I have implemented a reset_workaround_2 > clause (please feel free to suggest a better name!) to cover this > situation and added a quirk entry for the CSx laptops. > > Signed-off-by: John W. Linville Thanks! I applied it to ALSA tree now. Takashi