From: Takashi Iwai <tiwai@suse.de>
To: Russell King <rmk@arm.linux.org.uk>
Cc: Jaroslav Kysela <perex@suse.cz>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Jurriaan on Alpha <thunder7@xs4all.nl>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: compiling cmipci in 2.5.10 on Alpha doesn't work
Date: Fri, 26 Apr 2002 11:56:31 +0200 [thread overview]
Message-ID: <s5h4rhybx68.wl@alsa2.suse.de> (raw)
In-Reply-To: <20020426104017.B16265@flint.arm.linux.org.uk>
At Fri, 26 Apr 2002 10:40:17 +0100,
Russell King wrote:
>
> On Fri, Apr 26, 2002 at 11:17:23AM +0200, Jaroslav Kysela wrote:
> > The real fix is to add '#include <linux/pci.h>' line to all necessary
> > source files (sound/pci/cmipci.c in this example). Not all source files
> > need pci.h for compilation.
>
> You'd also need to forward-declare struct pci_dev in sound/driver.h to
> stop the compiler complaining about 'struct pci_dev' in function
> prototypes.
struct pci_dev in sound/driver.h is used only for i386 and ppc, so
it's not problem.
but it's true for sound/core.h. we use the struct there, too, for
general cases.
Takashi
next prev parent reply other threads:[~2002-04-26 9:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-04-26 7:31 Jurriaan on Alpha
2002-04-26 7:44 ` Jurriaan on Alpha
2002-04-26 9:05 ` Ivan Kokshaysky
2002-04-26 9:17 ` Jaroslav Kysela
2002-04-26 9:40 ` Russell King
2002-04-26 9:56 ` Takashi Iwai [this message]
2002-04-26 10:18 ` Ivan Kokshaysky
2002-04-26 10:26 ` Jaroslav Kysela
2002-04-26 10:49 ` Ivan Kokshaysky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h4rhybx68.wl@alsa2.suse.de \
--to=tiwai@suse.de \
--cc=ink@jurassic.park.msu.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@suse.cz \
--cc=rmk@arm.linux.org.uk \
--cc=thunder7@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®