From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C5D1C433F5 for ; Thu, 10 Mar 2022 14:03:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242647AbiCJOEF (ORCPT ); Thu, 10 Mar 2022 09:04:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59186 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242640AbiCJOED (ORCPT ); Thu, 10 Mar 2022 09:04:03 -0500 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B613C8BE38 for ; Thu, 10 Mar 2022 06:03:01 -0800 (PST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id F05FF210E9; Thu, 10 Mar 2022 14:02:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1646920979; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cT3dEO1xJTRPVumYeIvPPu1SHUArEx384wqIf7FTOS8=; b=ksQ0aeN9krn4d0er3l0gCJBwOWnl2/y3H2evub/Jzli1faQotpj608Et54rigf6un5+yMH JxtbyJcH/N9ALH6ukhg3TLtiRwXWTpfHFSLeL3+TmU9pouK/jrFzBrYi0FlJ3SP7tJxRdr OzT78KbRCObpps9tjj2udeU51RS+kGA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1646920979; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cT3dEO1xJTRPVumYeIvPPu1SHUArEx384wqIf7FTOS8=; b=33c0q/WzR/zAPyGVXPVRWgYDRPbRYDvS5SD27rfPl7krCyB8ylN+MR/kKbCFrb9BuvtcZv fpm5kSVKl0DgL3DA== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 6DAC5A3B81; Thu, 10 Mar 2022 14:02:59 +0000 (UTC) Date: Thu, 10 Mar 2022 15:02:59 +0100 Message-ID: From: Takashi Iwai To: =?UTF-8?B?Ium7hOaWh+i+iSI=?= Cc: "perex" , "tiwai" , "jeremy.szu" , "hui.wang" , "wse" , "cam" , "kailang" , "tanureal" , "sami" , "alsa-devel" , "linux-kernel" Subject: Re: [PATCH] ALSA: hda/realtek - Fix headset mic problem for a HP machine with alc671 In-Reply-To: References: <20220310130301.22827-1-huangwenhuia@uniontech.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 10 Mar 2022 14:58:36 +0100, 黄文辉 wrote: > > Hi Takashi, > > Thank you for your reply. > > When booting with plugged headset, the headphone will be muted. The muted state is the default behavior. Wouldn't it be unmuted if you adjust the corresponding mixer element? Takashi > > Thanks. > > ------------------ Original ------------------ > From: "Takashi Iwai"; > Date: Thu, Mar 10, 2022 09:29 PM > To: "huangwenhui"; > Cc: "perex"; "tiwai"; "jeremy.szu" > ; "hui.wang"; "wse" > ; "cam"; "kailang" > ; "tanureal"; "sami" > ; "alsa-devel"; "linux-kernel" > ; > Subject: Re: [PATCH] ALSA: hda/realtek - Fix headset mic problem for a HP > machine with alc671 > > On Thu, 10 Mar 2022 14:03:01 +0100, > huangwenhui wrote: > > > > On a HP 288 Pro G8, the front Mic could not be detected. > > > > Signed-off-by: huangwenhui > > Thanks for the patch. Most of the changes look OK, but one thing I > still don't get: > > > + case HDA_FIXUP_ACT_INIT: > > + alc_write_coef_idx(codec, 0x19, 0xa054); > > + msleep(80); > > + snd_hda_codec_write(codec, hp_pin, 0, > > + AC_VERB_SET_AMP_GAIN_MUTE, AMP_OUT_UNMUTE); > > Why this unconditional unmute is required for fixing the mic problem? > > Takashi > >