From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2F38C432BE for ; Sun, 1 Aug 2021 08:05:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8399261054 for ; Sun, 1 Aug 2021 08:05:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231478AbhHAIF6 (ORCPT ); Sun, 1 Aug 2021 04:05:58 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:34294 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230087AbhHAIF5 (ORCPT ); Sun, 1 Aug 2021 04:05:57 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 2869622047; Sun, 1 Aug 2021 08:05:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1627805149; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bShZYYYw9gzAU9l1zpGdsOfxjisudXefIX46w2pnN4U=; b=iPH8gy39Dns6MSRve5hLOOrolMWynGDNHVYEukQjhusgVTwrz1vFsKpQCYHvQtfeP442Im hcxlQuuEArF28yE5TEU2Q0t5r3Fy2rL6MFG2udK7ZRJntSdiy1lYRDMOcRdhraMB8wlHoI UtUJTlyTc+uVoKgTXFamrVD/8ckfpQQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1627805149; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bShZYYYw9gzAU9l1zpGdsOfxjisudXefIX46w2pnN4U=; b=vWketJyJpjbP1Q8vDq02caFxrWnT6rbMFUMJKtBkfeEAggOsZjEUQB2LIpNx4+S4E8ll4g 6ddIZ3+e+07q4ZCA== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 1ECEEA3BA8; Sun, 1 Aug 2021 08:05:49 +0000 (UTC) Date: Sun, 01 Aug 2021 10:05:49 +0200 Message-ID: From: Takashi Iwai To: Colin King Cc: Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: usb-audio: make array static const, makes object smaller In-Reply-To: <20210801062548.137770-1-colin.king@canonical.com> References: <20210801062548.137770-1-colin.king@canonical.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 01 Aug 2021 08:25:48 +0200, Colin King wrote: > > From: Colin Ian King > > Don't populate array names_to_check on the stack but instead it > static. Makes the object code smaller by 56 bytes. > > Before: > text data bss dec hex filename > 103512 34380 0 137892 21aa4 ./sound/usb/mixer.o > > After: > text data bss dec hex filename > 103264 34572 0 137836 21a6c ./sound/usb/mixer.o > > gcc version 10.2.0) > > Signed-off-by: Colin Ian King > --- > sound/usb/mixer.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/sound/usb/mixer.c b/sound/usb/mixer.c > index f4cdaf1ba44a..aec2499284a5 100644 > --- a/sound/usb/mixer.c > +++ b/sound/usb/mixer.c > @@ -1572,8 +1572,9 @@ static size_t append_ctl_name(struct snd_kcontrol *kctl, const char *str) > static void check_no_speaker_on_headset(struct snd_kcontrol *kctl, > struct snd_card *card) > { > - const char *names_to_check[] = { > - "Headset", "headset", "Headphone", "headphone", NULL}; > + static const char *names_to_check[] = { > + "Headset", "headset", "Headphone", "headphone", NULL > + }; checkpatch complains like: WARNING: static const char * array should probably be static const char * const Could you check and resubmit if it's right? thanks, Takashi