From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 330D1C07E96 for ; Thu, 8 Jul 2021 09:00:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 06C6161C92 for ; Thu, 8 Jul 2021 09:00:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231256AbhGHJCy (ORCPT ); Thu, 8 Jul 2021 05:02:54 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:54756 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231210AbhGHJCx (ORCPT ); Thu, 8 Jul 2021 05:02:53 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 2A0832017C; Thu, 8 Jul 2021 09:00:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1625734811; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zXBWX1J/SEQW1rLMlM4E1KFMEHbyBytq18w6+wHvhHE=; b=rH76wpsFPwPSCwy+j+WN+5Ylls3pePbrNr8gVu0eLbDdZ7BNfpcz0gTTl9jeO7a+7r4LHZ Mx74uy+IZmGQZUk/rvTE3KxyPmKiGRDhjo0fCgTbLPJriGWSsNHSIgsGLPpp+94b4D5rch /RMhO/TfvKJW5EzLaMoy8hArDXdf78Y= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1625734811; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zXBWX1J/SEQW1rLMlM4E1KFMEHbyBytq18w6+wHvhHE=; b=jJ5khGtePHBx7PzxYRTZudOtCuVWq1fxcw+aW5ks5f23aPGMemVafe0SeIEcydk3qkCMdw RNrQuoekofssXNCg== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 163AA2C1FE; Thu, 8 Jul 2021 09:00:11 +0000 (UTC) Date: Thu, 08 Jul 2021 11:00:11 +0200 Message-ID: From: Takashi Iwai To: Max Filippov Cc: Sergey Senozhatsky , alsa-devel@alsa-project.org, Leon Romanovsky , Takashi Iwai , LKML , "Gustavo A. R. Silva" Subject: Re: ALSA: intel8x0: div by zero in snd_intel8x0_update() In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 08 Jul 2021 10:41:50 +0200, Max Filippov wrote: > > On Thu, Jul 8, 2021 at 12:13 AM Takashi Iwai wrote: > > On Wed, 07 Jul 2021 22:33:22 +0200, > > Max Filippov wrote: > > > > > > On Wed, Jul 7, 2021 at 11:14 AM Takashi Iwai wrote: > > > > On Wed, 07 Jul 2021 19:50:07 +0200, Max Filippov wrote: > > > > > It didn't change anything in my case. My further observation is that > > > > > the snd_intel8x0_update is called before the ichdev->prepared > > > > > is set to one and as a result IRQ is apparently never cleared. > > > > > > > > So it's broken in anyway no matter whether > > > > intel8x0_measure_ac97_clock() is called or not, right? > > > > > > The change that you suggested didn't eliminate the call to > > > intel8x0_measure_ac97_clock, it's still called and an interrupt > > > flood happens at the same place. > > > > Ah I see the point. Then the fix would be a oneliner like below. > > > > > > Takashi > > > > --- a/sound/pci/intel8x0.c > > +++ b/sound/pci/intel8x0.c > > @@ -694,7 +694,7 @@ static inline void snd_intel8x0_update(struct intel8x0 *chip, struct ichdev *ich > > int status, civ, i, step; > > int ack = 0; > > > > - if (!ichdev->prepared || ichdev->suspended) > > + if (!(ichdev->prepared || ichdev->in_measurement) || ichdev->suspended) > > There's no ichdev::in_measurement, but if replaced with > chip->in_measurement it indeed fixes my issue. One must compile the code before sending out :-< > So with this change: > Tested-by: Max Filippov Great, thanks for quick testing, I'll prepare the fix patch now. Takashi