From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBCC8C41604 for ; Wed, 7 Oct 2020 15:31:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 742AB21582 for ; Wed, 7 Oct 2020 15:31:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727442AbgJGPbd (ORCPT ); Wed, 7 Oct 2020 11:31:33 -0400 Received: from mx2.suse.de ([195.135.220.15]:52054 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726697AbgJGPbc (ORCPT ); Wed, 7 Oct 2020 11:31:32 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 57BFCAD29; Wed, 7 Oct 2020 15:31:31 +0000 (UTC) Date: Wed, 07 Oct 2020 17:31:29 +0200 Message-ID: From: Takashi Iwai To: Jian-Hong Pan Cc: Takashi Iwai , Kailang Yang , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, linux@endlessm.com Subject: Re: [PATCH v2] ALSA: hda/realtek: Enable audio jacks of ASUS D700SA with ALC887 In-Reply-To: <20201007052224.22611-1-jhp@endlessos.org> References: <20201007052224.22611-1-jhp@endlessos.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 07 Oct 2020 07:22:25 +0200, Jian-Hong Pan wrote: > > The ASUS D700SA desktop's audio (1043:2390) with ALC887 cannot detect > the headset microphone and another headphone jack until > ALC887_FIXUP_ASUS_HMIC and ALC887_FIXUP_ASUS_AUDIO quirks are applied. > The NID 0x15 maps as the headset microphone and NID 0x19 maps as another > headphone jack. Also need the function like alc887_fixup_asus_jack to > enable the audio jacks. > > Signed-off-by: Jian-Hong Pan > Signed-off-by: Kailang Yang > --- > v2: > - Change the magic numbers to meaningful macros. > - Change snd_hda_codec_write to snd_hda_set_pin_ctl and > snd_hda_set_pin_ctl_cache accroding to Takashi's suggestion Thanks, applied. Takashi