From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37682C3A5A1 for ; Thu, 22 Aug 2019 15:22:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0B3E22089E for ; Thu, 22 Aug 2019 15:22:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389142AbfHVPWG (ORCPT ); Thu, 22 Aug 2019 11:22:06 -0400 Received: from mx2.suse.de ([195.135.220.15]:41008 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725892AbfHVPWG (ORCPT ); Thu, 22 Aug 2019 11:22:06 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 21791AE14; Thu, 22 Aug 2019 15:22:05 +0000 (UTC) Date: Thu, 22 Aug 2019 17:22:04 +0200 Message-ID: From: Takashi Iwai To: YueHaibing Cc: , , , , , , , Subject: Re: [PATCH -next] ALSA: line6: Fix -Wunused-const-variable warnings In-Reply-To: <20190822145741.9592-1-yuehaibing@huawei.com> References: <20190822145741.9592-1-yuehaibing@huawei.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 22 Aug 2019 16:57:41 +0200, YueHaibing wrote: > > sound/usb/line6/driver.h:69:18: warning: > SYSEX_DATA_OFS defined but not used [-Wunused-const-variable=] > sound/usb/line6/driver.h:70:18: warning: > SYSEX_EXTRA_SIZE defined but not used [-Wunused-const-variable=] > > SYSEX_EXTRA_SIZE is only used in driver.c and > SYSEX_DATA_OFS in pod.c, so move them to .c fix > this warning. > > Reported-by: Hulk Robot > Signed-off-by: YueHaibing No, this makes things worse. It should have been simply a normal define instead. Care to resend the fix with replacement to define? thanks, Takashi > --- > sound/usb/line6/driver.c | 2 ++ > sound/usb/line6/driver.h | 3 --- > sound/usb/line6/pod.c | 2 ++ > 3 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/sound/usb/line6/driver.c b/sound/usb/line6/driver.c > index b5a3f75..8027da8 100644 > --- a/sound/usb/line6/driver.c > +++ b/sound/usb/line6/driver.c > @@ -31,6 +31,8 @@ const unsigned char line6_midi_id[3] = { > }; > EXPORT_SYMBOL_GPL(line6_midi_id); > > +static const int SYSEX_EXTRA_SIZE = sizeof(line6_midi_id) + 4; > + > /* > Code to request version of POD, Variax interface > (and maybe other devices). > diff --git a/sound/usb/line6/driver.h b/sound/usb/line6/driver.h > index e5e572e..c57633a 100644 > --- a/sound/usb/line6/driver.h > +++ b/sound/usb/line6/driver.h > @@ -66,9 +66,6 @@ > > extern const unsigned char line6_midi_id[3]; > > -static const int SYSEX_DATA_OFS = sizeof(line6_midi_id) + 3; > -static const int SYSEX_EXTRA_SIZE = sizeof(line6_midi_id) + 4; > - > /* > Common properties of Line 6 devices. > */ > diff --git a/sound/usb/line6/pod.c b/sound/usb/line6/pod.c > index ee4c9d2..24ad337 100644 > --- a/sound/usb/line6/pod.c > +++ b/sound/usb/line6/pod.c > @@ -110,6 +110,8 @@ enum { > POD_BUSY_MIDISEND > }; > > +static const int SYSEX_DATA_OFS = sizeof(line6_midi_id) + 3; > + > static struct snd_ratden pod_ratden = { > .num_min = 78125, > .num_max = 78125, > -- > 2.7.4 > > >