From: Takashi Iwai <tiwai@suse.de>
To: "Bhumika Goyal" <bhumirks@gmail.com>
Cc: <alsa-devel@alsa-project.org>, <julia.lawall@lip6.fr>,
<perex@perex.cz>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA: ice1712: add const to snd_ak4xxx_private structures
Date: Sun, 06 Aug 2017 22:17:18 +0200 [thread overview]
Message-ID: <s5h60e030z5.wl-tiwai@suse.de> (raw)
In-Reply-To: <1501860881-7025-1-git-send-email-bhumirks@gmail.com>
On Fri, 04 Aug 2017 17:34:41 +0200,
Bhumika Goyal wrote:
>
> Declare snd_ak4xxx_private structures as const as they are only passed
> to the function snd_ice1712_akm4xxx_init. This argument is of type const,
> so make the structures const.
> Done using Coccinelle:
>
> @match disable optional_qualifier@
> identifier s;
> position p;
> @@
> static struct snd_ak4xxx_private s@p={...};
>
> @good1@
> identifier match.s;
> position p;
> @@
> snd_ice1712_akm4xxx_init(...,&s@p,...)
>
> @bad@
> identifier match.s;
> position p!={match.p,good1.p};
> @@
> s@p
>
> @depends on !bad disable optional_qualifier@
> identifier match.s;
> @@
> static
> +const
> struct snd_ak4xxx_private s={...};
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Applied, thanks.
Takashi
prev parent reply other threads:[~2017-08-06 20:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-04 15:34 Bhumika Goyal
2017-08-06 20:17 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h60e030z5.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=bhumirks@gmail.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®