From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751521AbdAPNeQ (ORCPT ); Mon, 16 Jan 2017 08:34:16 -0500 Received: from mx2.suse.de ([195.135.220.15]:59864 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751212AbdAPNeO (ORCPT ); Mon, 16 Jan 2017 08:34:14 -0500 Date: Mon, 16 Jan 2017 14:34:11 +0100 Message-ID: From: Takashi Iwai To: "Arnd Bergmann" Cc: "Jaroslav Kysela" , , , Subject: Re: [PATCH v3] ALSA: mips: avoid potential uninitialized variable use In-Reply-To: <20170116132805.2207208-1-arnd@arndb.de> References: <20170116132805.2207208-1-arnd@arndb.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 16 Jan 2017 14:27:57 +0100, Arnd Bergmann wrote: > > MIPS allmodconfig results in this warning: > > sound/mips/hal2.c: In function 'hal2_gain_get': > sound/mips/hal2.c:224:35: error: 'r' may be used uninitialized in this function [-Werror=maybe-uninitialized] > sound/mips/hal2.c:223:35: error: 'l' may be used uninitialized in this function [-Werror=maybe-uninitialized] > sound/mips/hal2.c: In function 'hal2_gain_put': > sound/mips/hal2.c:260:13: error: 'new' may be used uninitialized in this function [-Werror=maybe-uninitialized] > sound/mips/hal2.c:260:13: error: 'old' may be used uninitialized in this function [-Werror=maybe-uninitialized] > > Returning an error for all unexpected cases shuts up the warning > > Signed-off-by: Arnd Bergmann > --- > v3: actually send the correct patch, sorry for the mixup > v2: return an error instead trying to handle gracefully Thanks, applied now. Takashi