From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751860AbbKBHqw (ORCPT ); Mon, 2 Nov 2015 02:46:52 -0500 Received: from mx2.suse.de ([195.135.220.15]:53602 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751310AbbKBHqt (ORCPT ); Mon, 2 Nov 2015 02:46:49 -0500 Date: Mon, 02 Nov 2015 08:46:47 +0100 Message-ID: From: Takashi Iwai To: "Ondrej Zary" Cc: , "Kernel development list" Subject: Re: [PATCH] snd-maestro3: Fix Allegro mute until master volume/mute is touched In-Reply-To: <1446407594-2382-1-git-send-email-linux@rainbow-software.org> References: <1446407594-2382-1-git-send-email-linux@rainbow-software.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 01 Nov 2015 20:53:14 +0100, Ondrej Zary wrote: > > ESS Allegro (marked ES1989S), [125d:1988] (rev 10) is mute after > loading snd-maestro3 and running alsactl restore. Touching master > volume or mute makes it work. > > Looks like a bug in the AC'97 codec integrated into the chip. > > Write AC97_MASTER register twice to work-around the problem. > > Signed-off-by: Ondrej Zary Applied, thanks. Takashi > --- > sound/pci/maestro3.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/sound/pci/maestro3.c b/sound/pci/maestro3.c > index 965d5c6..17ae926 100644 > --- a/sound/pci/maestro3.c > +++ b/sound/pci/maestro3.c > @@ -1929,6 +1929,16 @@ snd_m3_ac97_write(struct snd_ac97 *ac97, unsigned short reg, unsigned short val) > return; > snd_m3_outw(chip, val, CODEC_DATA); > snd_m3_outb(chip, reg & 0x7f, CODEC_COMMAND); > + /* > + * Workaround for buggy ES1988 integrated AC'97 codec. It remains silent > + * until the MASTER volume or mute is touched (alsactl restore does not > + * work). > + */ > + if (ac97->id == 0x45838308 && reg == AC97_MASTER) { > + snd_m3_ac97_wait(chip); > + snd_m3_outw(chip, val, CODEC_DATA); > + snd_m3_outb(chip, reg & 0x7f, CODEC_COMMAND); > + } > } > > > -- > Ondrej Zary > > . >