From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757311AbbJ2OgP (ORCPT ); Thu, 29 Oct 2015 10:36:15 -0400 Received: from mx2.suse.de ([195.135.220.15]:55400 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753545AbbJ2OgN (ORCPT ); Thu, 29 Oct 2015 10:36:13 -0400 Date: Thu, 29 Oct 2015 15:36:11 +0100 Message-ID: From: Takashi Iwai To: Vincent ABRIOU Cc: Benjamin Gaignard , David Airlie , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] drm/sti: Remove select of CONFIG_FW_LOADER_USER_HELPER_FALLBACK In-Reply-To: <56322B6F.5080101@st.com> References: <1445235370-6717-1-git-send-email-tiwai@suse.de> <56322B6F.5080101@st.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 29 Oct 2015 15:21:35 +0100, Vincent ABRIOU wrote: > > Hi Takashi, > > Removing FW_LOADER_USER_HELPER_FALLBACK leads to a failure in our HQVDP > firmware execution. > Indeed, our firmware is not built-in. It is a proprietary firmware > uploaded into the file system that's why we need the > USER_HELPER_FALLBACK to be able to load it once file system is available. It's not the option a driver can set. It's a global control option that is applied *all* drivers. If the fallback behavior is mandatory by a weird reason, you'd need to adjust in a different way; e.g. modify the firmware loader code to provide a new API for the driver to give a fallback (i.e. the another flip of request_firmware_direct()) and use that API explicitly. But I don't believe it's the case. Judging from your comment, it's your system setup that requires the user-space fallback. So don't make the fallback thing mandatory. thanks, Takashi > > BR > Vincent > > On 10/19/2015 08:16 AM, Takashi Iwai wrote: > > The commit [4fdbc678fe4d: drm: sti: add HQVDP plane] added the select > > of CONFIG_FW_LOADER_USER_HELPER_FALLBACK by some unwritten reason. > > But this config is known to be harmful, and is present only for > > compatibility reason for an old exotic system that mandates udev > > interaction which isn't supposed to be selected by a driver. > > Let's remove it. > > > > Fixes: 4fdbc678fe4d ('drm: sti: add HQVDP plane') > > Cc: > > Signed-off-by: Takashi Iwai > > --- > > drivers/gpu/drm/sti/Kconfig | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/sti/Kconfig b/drivers/gpu/drm/sti/Kconfig > > index fbccc105819b..a18159074b76 100644 > > --- a/drivers/gpu/drm/sti/Kconfig > > +++ b/drivers/gpu/drm/sti/Kconfig > > @@ -6,7 +6,6 @@ config DRM_STI > > select DRM_GEM_CMA_HELPER > > select DRM_KMS_CMA_HELPER > > select DRM_PANEL > > - select FW_LOADER_USER_HELPER_FALLBACK > > help > > Choose this option to enable DRM on STM stiH41x chipset > > > >