From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751097AbbCKGJc (ORCPT ); Wed, 11 Mar 2015 02:09:32 -0400 Received: from cantor2.suse.de ([195.135.220.15]:52868 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750755AbbCKGJ2 (ORCPT ); Wed, 11 Mar 2015 02:09:28 -0400 Date: Wed, 11 Mar 2015 07:09:26 +0100 Message-ID: From: Takashi Iwai To: Mikko Rapeli Cc: Arnd Bergmann , linux-kernel@vger.kernel.org, Jaroslav Kysela , alsa-devel@alsa-project.org, linux-api@vger.kernel.org Subject: Re: [PATCH 24/45] hdspm.h: include stdint.h in userspace In-Reply-To: <20150311002812.GB12550@lakka.kapsi.fi> References: <1424127948-22484-1-git-send-email-mikko.rapeli@iki.fi> <1424127948-22484-25-git-send-email-mikko.rapeli@iki.fi> <20150311002812.GB12550@lakka.kapsi.fi> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.4 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Wed, 11 Mar 2015 02:28:12 +0200, Mikko Rapeli wrote: > > On Tue, Feb 17, 2015 at 07:46:02AM +0100, Takashi Iwai wrote: > > At Tue, 17 Feb 2015 00:05:27 +0100, > > Mikko Rapeli wrote: > > > > > > Fixes compilation error: > > > > > > sound/hdspm.h:43:2: error: unknown type name ‘uint32_t’ > > > > > > Signed-off-by: Mikko Rapeli > > > > Applied for 3.21, thanks. > > Sorry, but this should maybe be dropped or reverted from the sound tree. > > Arnd and others pointed out that kernel headers should be using __u32 etc > types from linux/types.h instead of including stdint.h from libc and using > uint32_t et al. > > I'll post a new patch version for hdspm.h too in the next revision. Then please post an incremental patch to for-next branch of sound git tree (or the current linux-next tree). Takashi