From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753079AbaIVHE4 (ORCPT ); Mon, 22 Sep 2014 03:04:56 -0400 Received: from cantor2.suse.de ([195.135.220.15]:55838 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752632AbaIVHEz (ORCPT ); Mon, 22 Sep 2014 03:04:55 -0400 Date: Mon, 22 Sep 2014 09:04:53 +0200 Message-ID: From: Takashi Iwai To: Sudip Mukherjee Cc: Jaroslav Kysela , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/5] sound: pci: ctxfi: added reference of snd_card In-Reply-To: <1411315421-24138-1-git-send-email-sudipm.mukherjee@gmail.com> References: <1411315421-24138-1-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Sun, 21 Sep 2014 21:33:37 +0530, Sudip Mukherjee wrote: > > added and initialized a pointer of snd_card in the struct hw to get a reference of > the card in other functions You need to explain why this change is needed. The above text shows what it'd do, but it doesn't give any explanation to convince why this patch must be merged in. In this case, it's a preliminary patch for the changes to convert to dev_*() later. It's the most important bit, so don't forget it. thanks, Takashi > > Signed-off-by: Sudip Mukherjee > --- > sound/pci/ctxfi/ctatc.c | 1 + > sound/pci/ctxfi/cthardware.h | 2 ++ > 2 files changed, 3 insertions(+) > > diff --git a/sound/pci/ctxfi/ctatc.c b/sound/pci/ctxfi/ctatc.c > index d92a08c..b21eda4 100644 > --- a/sound/pci/ctxfi/ctatc.c > +++ b/sound/pci/ctxfi/ctatc.c > @@ -1333,6 +1333,7 @@ static int atc_create_hw_devs(struct ct_atc *atc) > pr_err("Failed to create hw obj!!!\n"); > return err; > } > + hw->card = atc->card; > atc->hw = hw; > > /* Initialize card hardware. */ > diff --git a/sound/pci/ctxfi/cthardware.h b/sound/pci/ctxfi/cthardware.h > index 5977e9a..940bbd0 100644 > --- a/sound/pci/ctxfi/cthardware.h > +++ b/sound/pci/ctxfi/cthardware.h > @@ -20,6 +20,7 @@ > > #include > #include > +#include > > enum CHIPTYP { > ATC20K1, > @@ -184,6 +185,7 @@ struct hw { > void *irq_callback_data; > > struct pci_dev *pci; /* the pci kernel structure of this card */ > + struct snd_card *card; /* pointer to this card */ > int irq; > unsigned long io_base; > unsigned long mem_base; > -- > 1.8.1.2 >