From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751433AbaIQFy0 (ORCPT ); Wed, 17 Sep 2014 01:54:26 -0400 Received: from cantor2.suse.de ([195.135.220.15]:51663 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751174AbaIQFyY (ORCPT ); Wed, 17 Sep 2014 01:54:24 -0400 Date: Wed, 17 Sep 2014 07:54:22 +0200 Message-ID: From: Takashi Iwai To: Rasmus Villemoes Cc: Andrew Morton , linux-kernel@vger.kernel.org, Jaroslav Kysela , alsa-devel@alsa-project.org Subject: Re: [PATCH 08/22] ALSA: hda - Replace strnicmp with strncasecmp In-Reply-To: <1410900696-6481-9-git-send-email-linux@rasmusvillemoes.dk> References: <1410900696-6481-1-git-send-email-linux@rasmusvillemoes.dk> <1410900696-6481-9-git-send-email-linux@rasmusvillemoes.dk> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Tue, 16 Sep 2014 22:51:22 +0200, Rasmus Villemoes wrote: > > The kernel used to contain two functions for length-delimited, > case-insensitive string comparison, strnicmp with correct semantics > and a slightly buggy strncasecmp. The latter is the POSIX name, so > strnicmp was renamed to strncasecmp, and strnicmp made into a wrapper > for the new strncasecmp to avoid breaking existing users. > > To allow the compat wrapper strnicmp to be removed at some point in > the future, and to avoid the extra indirection cost, do > s/strnicmp/strncasecmp/g. > > Cc: Jaroslav Kysela > Cc: Takashi Iwai > Cc: alsa-devel@alsa-project.org > Signed-off-by: Rasmus Villemoes Applied, thanks. Takashi > --- > sound/pci/hda/hda_sysfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/pci/hda/hda_sysfs.c b/sound/pci/hda/hda_sysfs.c > index e207909..9b49f15 100644 > --- a/sound/pci/hda/hda_sysfs.c > +++ b/sound/pci/hda/hda_sysfs.c > @@ -514,7 +514,7 @@ enum { > > static inline int strmatch(const char *a, const char *b) > { > - return strnicmp(a, b, strlen(b)) == 0; > + return strncasecmp(a, b, strlen(b)) == 0; > } > > /* parse the contents after the line "[codec]" > -- > 2.0.4 >