From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753554Ab3KGUXa (ORCPT ); Thu, 7 Nov 2013 15:23:30 -0500 Received: from cantor2.suse.de ([195.135.220.15]:41371 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751336Ab3KGUXY (ORCPT ); Thu, 7 Nov 2013 15:23:24 -0500 Date: Thu, 07 Nov 2013 21:23:23 +0100 Message-ID: From: Takashi Iwai To: Joe Perches Cc: alsa-devel , LKML Subject: Re: [RFC PATCH] hda_intel: ratelimit "spurious response" message In-Reply-To: <1383854115.9263.21.camel@joe-AO722> References: <1383854115.9263.21.camel@joe-AO722> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Thu, 07 Nov 2013 11:55:15 -0800, Joe Perches wrote: > > dmesg here has a 100+ consecutive lines of: > > [ 1464.219446] hda-intel 0000:00:14.2: spurious response 0x0:0x0, last cmd=0x170500 > [ 1464.219451] hda-intel 0000:00:14.2: spurious response 0x0:0x0, last cmd=0x170500 > [ 1464.219454] hda-intel 0000:00:14.2: spurious response 0x0:0x0, last cmd=0x170500 > ... > > Ratelimit the message to reduce the dmesg log noise. > > Coalesce the format while at it. > > Signed-off-by: Joe Perches Thanks, applied. BTW, which hardware shows this problem? I'm interested rather in that... Takashi > --- > sound/pci/hda/hda_intel.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c > index 6e61a01..6e444ca 100644 > --- a/sound/pci/hda/hda_intel.c > +++ b/sound/pci/hda/hda_intel.c > @@ -906,12 +906,12 @@ static void azx_update_rirb(struct azx *chip) > chip->rirb.res[addr] = res; > smp_wmb(); > chip->rirb.cmds[addr]--; > - } else > - snd_printk(KERN_ERR SFX "%s: spurious response %#x:%#x, " > - "last cmd=%#08x\n", > + } else if (printk_ratelimit()) { > + snd_printk(KERN_ERR SFX "%s: spurious response %#x:%#x, last cmd=%#08x\n", > pci_name(chip->pci), > res, res_ex, > chip->last_cmd[addr]); > + } > } > } > > >