mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Ondrej Zary <linux@rainbow-software.org>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH 2/2] [RESEND] snd-ac97-codec: Use complete ID	when the codec is not known
Date: Mon, 30 Sep 2013 11:08:50 +0200	[thread overview]
Message-ID: <s5h61ti7k2l.wl%tiwai@suse.de> (raw)
In-Reply-To: <201309272028.03764.linux@rainbow-software.org>

At Fri, 27 Sep 2013 20:28:03 +0200,
Ondrej Zary wrote:
> 
> Currently, if the codec ID is not known, the last byte of the ID is used as name.
> It's not helpful at all, use full codec ID instead.

The full bytes are already shown at the beginning, no?
It's masked because the upper three bytes are shown in printable form,
and the last byte is usually a model number.


Takashi

> 
> Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
> ---
>  sound/pci/ac97/ac97_codec.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/sound/pci/ac97/ac97_codec.c b/sound/pci/ac97/ac97_codec.c
> index bf578ba2..30a40a8 100644
> --- a/sound/pci/ac97/ac97_codec.c
> +++ b/sound/pci/ac97/ac97_codec.c
> @@ -1830,7 +1830,7 @@ void snd_ac97_get_name(struct snd_ac97 *ac97, unsigned int id, char *name, int m
>  				pid->patch(ac97);
>  		}
>  	} else
> -		sprintf(name + strlen(name), " id %x", id & 0xff);
> +		sprintf(name + strlen(name), " id %x", id);
>  }
>  
>  /**
> -- 
> Ondrej Zary
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> 

  reply	other threads:[~2013-09-30  9:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-27 18:28 Ondrej Zary
2013-09-30  9:08 ` Takashi Iwai [this message]
2013-09-30 18:42   ` [alsa-devel] " Ondrej Zary

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h61ti7k2l.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rainbow-software.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®