From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755204Ab3A1Iry (ORCPT ); Mon, 28 Jan 2013 03:47:54 -0500 Received: from cantor2.suse.de ([195.135.220.15]:47390 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753823Ab3A1Irw (ORCPT ); Mon, 28 Jan 2013 03:47:52 -0500 Date: Mon, 28 Jan 2013 09:47:46 +0100 Message-ID: From: Takashi Iwai To: Emil Goode Cc: mtosatti@redhat.com, gleb@redhat.com, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, avi@redhat.com, mst@redhat.com, perex@perex.cz, crimsun@ubuntu.com, wfp5p@virginia.edu, peter.senna@gmail.com, x86@kernel.org, kvm@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 3/3] ALSA: intel8x0: Check return value before assigning In-Reply-To: <1359304802-28240-3-git-send-email-emilgoode@gmail.com> References: <1359304802-28240-1-git-send-email-emilgoode@gmail.com> <1359304802-28240-3-git-send-email-emilgoode@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Sun, 27 Jan 2013 17:40:02 +0100, Emil Goode wrote: > > The first patch in this series changes the return type of function > kvm_para_available to bool. In the function snd_intel8x0_inside_vm > we now need to check it's return value before assigning a value to > the result variable. > > Signed-off-by: Emil Goode > --- > sound/pci/intel8x0.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/pci/intel8x0.c b/sound/pci/intel8x0.c > index 3b9be75..fa9337e 100644 > --- a/sound/pci/intel8x0.c > +++ b/sound/pci/intel8x0.c > @@ -2982,7 +2982,7 @@ static int snd_intel8x0_inside_vm(struct pci_dev *pci) > } > > /* detect KVM and Parallels virtual environments */ > - result = kvm_para_available(); > + result = kvm_para_available() ? 1 : 0; This is superfluous. The conversion from bool to int works implicitly like that. Takashi