From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752436Ab1E1GX4 (ORCPT ); Sat, 28 May 2011 02:23:56 -0400 Received: from cantor2.suse.de ([195.135.220.15]:44105 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751571Ab1E1GXy (ORCPT ); Sat, 28 May 2011 02:23:54 -0400 Date: Sat, 28 May 2011 08:23:52 +0200 Message-ID: From: Takashi Iwai To: Linus Torvalds Cc: Mark Brown , Liam Girdwood , linux-kernel@vger.kernel.org Subject: Re: [GIT PULL] sound updates #2 for 2.6.40 In-Reply-To: References: User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Fri, 27 May 2011 19:44:54 -0700, Linus Torvalds wrote: > > On Fri, May 27, 2011 at 7:41 PM, Linus Torvalds > wrote: > > > > Looking at that diff, I found at least one bug: > > > > -       if (chip->driver_type != AZX_DRIVER_ATI && > > -           chip->driver_type != AZX_DRIVER_ATIHDMI) > > +       if (chip->driver_caps & AZX_DCAPS_NO_TCSEL) { > > > > That's wrong. It should be > > > >        if (!(chip->driver_caps & AZX_DCAPS_NO_TCSEL)) { > > > > but I haven't checked if that fixes it for me yet. > > Yup, that's it. Apparently if you don't clear the TCSEL bit, you get > random static and repeated stuff. > > And the reason the conversion was wrong is that the bit is not a > "feature" bit, it's a "lack of feature" bit, but the conversion missed > the negation. My bad. I concentrated on fixing AMD issues, and this was a part of it. Obviously I didn't test Intel boxes carefully enough. Sorry for taking your time! Takashi