Re: [PATCH] sound/pci/asihpi: check adapter index in hpi_ioctl

[Takashi Iwai <tiwai@suse.de>]

At Thu, 17 Mar 2011 18:32:24 -0400,
Dan Rosenberg wrote:
> 
> The user-supplied index into the adapters array needs to be checked, or
> an out-of-bounds kernel pointer could be accessed and used, leading to
> potentially exploitable memory corruption.
> 
> Signed-off-by: Dan Rosenberg <drosenberg@vsecurity.com>

Applied now (with Cc to stable kernel).  Thanks.


Takashi

> ---
>  sound/pci/asihpi/hpioctl.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/sound/pci/asihpi/hpioctl.c b/sound/pci/asihpi/hpioctl.c
> index 22dbd91..448dd01 100644
> --- a/sound/pci/asihpi/hpioctl.c
> +++ b/sound/pci/asihpi/hpioctl.c
> @@ -155,6 +155,11 @@ long asihpi_hpi_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
>  		goto out;
>  	}
>  
> +	if (hm->h.adapter_index >= HPI_MAX_ADAPTERS) {
> +		err = -EINVAL;
> +		goto out;
> +	}
> +
>  	pa = &adapters[hm->h.adapter_index];
>  	hr->h.size = 0;
>  	if (hm->h.object == HPI_OBJ_SUBSYSTEM) {
> 
>