From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756772Ab0G2KbF (ORCPT ); Thu, 29 Jul 2010 06:31:05 -0400 Received: from cantor2.suse.de ([195.135.220.15]:51610 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756725Ab0G2KbB (ORCPT ); Thu, 29 Jul 2010 06:31:01 -0400 Date: Thu, 29 Jul 2010 12:31:00 +0200 Message-ID: From: Takashi Iwai To: Kulikov Vasiliy Cc: kernel-janitors@vger.kernel.org, Jaroslav Kysela , Tejun Heo , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 07/10] ALSA: sb: check get_user() return value In-Reply-To: <1280335251-23385-1-git-send-email-segooon@gmail.com> References: <1280335251-23385-1-git-send-email-segooon@gmail.com> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Wed, 28 Jul 2010 20:40:51 +0400, Kulikov Vasiliy wrote: > > get_user() may fail, if so return -EFAULT. > > Signed-off-by: Kulikov Vasiliy Thanks, applied this one (with one additional fix for get_user() there). Takashi > --- > sound/isa/sb/emu8000_pcm.c | 6 ++++-- > 1 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/sound/isa/sb/emu8000_pcm.c b/sound/isa/sb/emu8000_pcm.c > index ccedbfe..ae6fa9f 100644 > --- a/sound/isa/sb/emu8000_pcm.c > +++ b/sound/isa/sb/emu8000_pcm.c > @@ -433,7 +433,8 @@ static int emu8k_transfer_block(struct snd_emu8000 *emu, int offset, unsigned sh > while (count > 0) { > unsigned short sval; > CHECK_SCHEDULER(); > - get_user(sval, buf); > + if (get_user(sval, buf)) > + return -EFAULT; > EMU8000_SMLD_WRITE(emu, sval); > buf++; > count--; > @@ -525,7 +526,8 @@ static int emu8k_pcm_copy(struct snd_pcm_substream *subs, > while (count-- > 0) { > unsigned short sval; > CHECK_SCHEDULER(); > - get_user(sval, buf); > + if (get_user(sval, buf)) > + return -EFAULT; > EMU8000_SMLD_WRITE(emu, sval); > buf++; > if (rec->voices > 1) { > -- > 1.7.0.4 >