From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1754010AbZKLUMP@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754010AbZKLUMP (ORCPT <rfc822;w@1wt.eu>);
	Thu, 12 Nov 2009 15:12:15 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753435AbZKLUMN
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Thu, 12 Nov 2009 15:12:13 -0500
Received: from cantor.suse.de ([195.135.220.2]:42048 "EHLO mx1.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753194AbZKLUMN (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 12 Nov 2009 15:12:13 -0500
Date: Thu, 12 Nov 2009 21:12:17 +0100
Message-ID: <s5h639f1p0e.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: Jaroslav Kysela <perex@perex.cz>, alsa-devel@alsa-project.org,
       Andrew Morton <akpm@linux-foundation.org>,
       LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH]  OSS: fix error return in dma_ioctl()
In-Reply-To: <s5hocn7y8qy.wl%tiwai@suse.de>
References: <4AFC3B1F.1050901@gmail.com>
	<s5hocn7y8qy.wl%tiwai@suse.de>
User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.1
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

At Thu, 12 Nov 2009 18:04:53 +0100,
I wrote:
> 
> At Thu, 12 Nov 2009 17:43:11 +0100,
> Roel Kluin wrote:
> > 
> > The returned error should stay negative
> > 
> > Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> > ---
> >  sound/oss/audio.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/sound/oss/audio.c b/sound/oss/audio.c
> > index b69c05b..7df48a2 100644
> > --- a/sound/oss/audio.c
> > +++ b/sound/oss/audio.c
> > @@ -838,7 +838,7 @@ static int dma_ioctl(int dev, unsigned int cmd, void __user *arg)
> >  					if ((err = audio_devs[dev]->d->prepare_for_input(dev,
> >  						     dmap_in->fragment_size, dmap_in->nbufs)) < 0) {
> >  						spin_unlock_irqrestore(&dmap_in->lock,flags);
> > -						return -err;
> > +						return err;
> 
> Hmm, looks like a wrong fix to me.
> Here, err itself is already negative, so you don't need to flip the
> sign.

My bad, I looked at the patch in a reverse way.
Now applied.  Thanks!


Takashi