From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1752678AbYIMPTS@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752678AbYIMPTS (ORCPT <rfc822;w@1wt.eu>);
	Sat, 13 Sep 2008 11:19:18 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751174AbYIMPTF
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Sat, 13 Sep 2008 11:19:05 -0400
Received: from ns1.suse.de ([195.135.220.2]:42578 "EHLO mx1.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750967AbYIMPTE (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Sat, 13 Sep 2008 11:19:04 -0400
Date: Sat, 13 Sep 2008 17:19:01 +0200
Message-ID: <s5h63p09iqi.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: "Mike Frysinger" <vapier.adi@gmail.com>
Cc: tj@kernel.org, "Linux Kernel" <linux-kernel@vger.kernel.org>
Subject: Re: OSS sound core optionalization has __init/__exit mismatches
In-Reply-To: <8bd0f97a0809120822n40c8f99k45bb91e670cca805@mail.gmail.com>
References: <8bd0f97a0809120822n40c8f99k45bb91e670cca805@mail.gmail.com>
User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.2
 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

At Fri, 12 Sep 2008 11:22:21 -0400,
Mike Frysinger wrote:
> 
> this commit:
> commit 1be95f401657e75984871c369d774d507e462939
> Author: Tejun Heo <tj@kernel.org>
> Date:   Thu Aug 28 16:42:51 2008 +0200
> sound: make OSS sound core optional
> 
> results in this failure:
> WARNING: vmlinux.o(.init.text+0xfbf0): Section mismatch in reference
> from the function _init_soundcore() to the function
> .exit.text:_cleanup_oss_soundcore()
> The function __init _init_soundcore() references
> a function __exit _cleanup_oss_soundcore().
> This is often seen when error handling in the init function
> uses functionality in the exit path.
> The fix is often to remove the __exit annotation of
> _cleanup_oss_soundcore() so it may be used outside an exit section.
> 
> and can easily be seen in sound/sound_core.c:
> ...
> static int __init init_soundcore(void)
> {
> ...
>                cleanup_oss_soundcore();
> ...
> }
> ...
> static void __exit cleanup_oss_soundcore(void)
> {
> ...
> }
> ...
> -mike

Thanks for reporting.  It was already fixed on my sound-2.6.git.


Takashi