From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 677E7C4332F
	for <linux-kernel@archiver.kernel.org>; Wed, 27 Oct 2021 06:24:01 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 499C8610A0
	for <linux-kernel@archiver.kernel.org>; Wed, 27 Oct 2021 06:24:01 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S238554AbhJ0G0Z (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Wed, 27 Oct 2021 02:26:25 -0400
Received: from smtp-out2.suse.de ([195.135.220.29]:52788 "EHLO
        smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S230342AbhJ0G0W (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 27 Oct 2021 02:26:22 -0400
Received: from relay2.suse.de (relay2.suse.de [149.44.160.134])
        by smtp-out2.suse.de (Postfix) with ESMTP id 9341B1FD47;
        Wed, 27 Oct 2021 06:23:56 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
        t=1635315836; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
         mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=Ua2RExmAJ4Oar37g/9kkjA5B9D0zknkT1W1DLUdKtBM=;
        b=HjL3NWItkFHCKayxxs+U+EBdLODYLkZ9H4E8ixvmJgbs9+akqz7QyYghW438CWKxNVPxFN
        b/dPfc/TwNA44/Os1cwQLGwOGMiuKSdtPpHr7dN3qBRZ6e/MYaVtTepaP5jxfFaZBqdNiZ
        txx8NmpaOQWxuG6qNxvKv2eHQgyqdVk=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
        s=susede2_ed25519; t=1635315836;
        h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
         mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=Ua2RExmAJ4Oar37g/9kkjA5B9D0zknkT1W1DLUdKtBM=;
        b=87RWXEySjuuV1rfZGI1en85DOa9KoUPwsd3fTNMkQ7tCxyYi+sQ5C24i5BY4lgujeBqRUU
        wQ4izBLJJo8TZtAQ==
Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42])
        by relay2.suse.de (Postfix) with ESMTP id 67326A3B81;
        Wed, 27 Oct 2021 06:23:56 +0000 (UTC)
Date:   Wed, 27 Oct 2021 08:23:56 +0200
Message-ID: <s5h7ddzx9xf.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Johan Hovold <johan@kernel.org>
Cc:     Clemens Ladisch <clemens@ladisch.de>,
        Takashi Iwai <tiwai@suse.com>,
        Jaroslav Kysela <perex@perex.cz>, alsa-devel@alsa-project.org,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        stable@vger.kernel.org
Subject: Re: [PATCH] sound: ua101: fix division by zero at probe
In-Reply-To: <20211026095401.26522-1-johan@kernel.org>
References: <20211026095401.26522-1-johan@kernel.org>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 26 Oct 2021 11:54:01 +0200,
Johan Hovold wrote:
> 
> Add the missing endpoint max-packet sanity check to probe() to avoid
> division by zero in alloc_stream_buffers() in case a malicious device
> has broken descriptors (or when doing descriptor fuzz testing).
> 
> Note that USB core will reject URBs submitted for endpoints with zero
> wMaxPacketSize but that drivers doing packet-size calculations still
> need to handle this (cf. commit 2548288b4fb0 ("USB: Fix: Don't skip
> endpoint descriptors with maxpacket=0")).
> 
> Fixes: 63978ab3e3e9 ("sound: add Edirol UA-101 support")
> Cc: stable@vger.kernel.org      # 2.6.34
> Signed-off-by: Johan Hovold <johan@kernel.org>

Thanks, applied.


Takashi