From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6242EC433DB for ; Sun, 14 Mar 2021 08:31:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2051264E67 for ; Sun, 14 Mar 2021 08:31:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234944AbhCNIaa (ORCPT ); Sun, 14 Mar 2021 04:30:30 -0400 Received: from mx2.suse.de ([195.135.220.15]:50114 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234756AbhCNIaX (ORCPT ); Sun, 14 Mar 2021 04:30:23 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 85547AB8C; Sun, 14 Mar 2021 08:30:22 +0000 (UTC) Date: Sun, 14 Mar 2021 09:30:22 +0100 Message-ID: From: Takashi Iwai To: Pierre-Louis Bossart Cc: alsa-devel@alsa-project.org, broonie@kernel.org, linux-kernel@vger.kernel.org, Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Kuninori Morimoto Subject: Re: [PATCH 05/23] ASoC: cx2070x: remove useless assignment In-Reply-To: <20210312182246.5153-6-pierre-louis.bossart@linux.intel.com> References: <20210312182246.5153-1-pierre-louis.bossart@linux.intel.com> <20210312182246.5153-6-pierre-louis.bossart@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 12 Mar 2021 19:22:28 +0100, Pierre-Louis Bossart wrote: > > Cppcheck warning: > > sound/soc/codecs/cx2072x.c:830:26: style: Variable > 'reg1.r.rx_data_one_line' is reassigned a value before the old one has > been used. [redundantAssignment] > > reg1.r.rx_data_one_line = 1; > ^ > > sound/soc/codecs/cx2072x.c:782:26: note: reg1.r.rx_data_one_line is > assigned > reg1.r.rx_data_one_line = 1; > ^ > > sound/soc/codecs/cx2072x.c:830:26: note: reg1.r.rx_data_one_line is > overwritten > reg1.r.rx_data_one_line = 1; > ^ > > sound/soc/codecs/cx2072x.c:831:26: style: Variable > 'reg1.r.tx_data_one_line' is reassigned a value before the old one has > been used. [redundantAssignment] > reg1.r.tx_data_one_line = 1; > ^ > sound/soc/codecs/cx2072x.c:783:26: note: reg1.r.tx_data_one_line is > assigned > reg1.r.tx_data_one_line = 1; > ^ > > sound/soc/codecs/cx2072x.c:831:26: note: reg1.r.tx_data_one_line is > overwritten > reg1.r.tx_data_one_line = 1; > ^ > > Likely copy/paste. > > Signed-off-by: Pierre-Louis Bossart Reviewed-by: Takashi Iwai thanks, Takashi > --- > sound/soc/codecs/cx2072x.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/sound/soc/codecs/cx2072x.c b/sound/soc/codecs/cx2072x.c > index 8ab22815c2c9..d2d004654c9b 100644 > --- a/sound/soc/codecs/cx2072x.c > +++ b/sound/soc/codecs/cx2072x.c > @@ -827,9 +827,6 @@ static int cx2072x_config_i2spcm(struct cx2072x_priv *cx2072x) > } > regdbt2.r.i2s_bclk_invert = is_bclk_inv; > > - reg1.r.rx_data_one_line = 1; > - reg1.r.tx_data_one_line = 1; > - > /* Configures the BCLK output */ > bclk_rate = cx2072x->sample_rate * frame_len; > reg5.r.i2s_pcm_clk_div_chan_en = 0; > -- > 2.25.1 >