From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB823C433DB for ; Mon, 1 Feb 2021 08:18:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 87A0B64E33 for ; Mon, 1 Feb 2021 08:18:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232491AbhBAISF (ORCPT ); Mon, 1 Feb 2021 03:18:05 -0500 Received: from mx2.suse.de ([195.135.220.15]:48438 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229629AbhBAISC (ORCPT ); Mon, 1 Feb 2021 03:18:02 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 66A49B1A6; Mon, 1 Feb 2021 08:17:21 +0000 (UTC) Date: Mon, 01 Feb 2021 09:17:19 +0100 Message-ID: From: Takashi Iwai To: Dinghao Liu Cc: kjlu@umn.edu, Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: intel8x0: Fix missing check in snd_intel8x0m_create In-Reply-To: <20210131100916.7915-1-dinghao.liu@zju.edu.cn> References: <20210131100916.7915-1-dinghao.liu@zju.edu.cn> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 31 Jan 2021 11:09:14 +0100, Dinghao Liu wrote: > > When device_type == DEVICE_ALI, we should also check the return > value of pci_iomap() to avoid potential null pointer dereference. > > Signed-off-by: Dinghao Liu Thanks, applied. Takashi